Browse Source

ci : remove the LLAMA_ACCELERATE matrix dimension from Ubuntu builds in the CI (#1074)

[Accelerate](https://developer.apple.com/documentation/accelerate) is an Apple framework which can only be used on macOS, and the CMake build [ignores](https://github.com/ggerganov/llama.cpp/blob/master/CMakeLists.txt#L102) the `LLAMA_ACCELERATE` variable when run on non-Apple platforms. This implies setting `LLAMA_ACCELERATE` is a no-op on Ubuntu and can be removed.

This will reduce visual noise in CI check results (in addition to reducing the number of checks we have to run for every PR). Right now every sanitized build is duplicated twice for no good reason (e.g., we have `CI / ubuntu-latest-cmake-sanitizer (ADDRESS, Debug, ON)` and `CI / ubuntu-latest-cmake-sanitizer (ADDRESS, Debug, OFF)`).
Ivan Komarov 2 years ago
parent
commit
6a9661ea5a
1 changed files with 1 additions and 2 deletions
  1. 1 2
      .github/workflows/build.yml

+ 1 - 2
.github/workflows/build.yml

@@ -81,7 +81,6 @@ jobs:
       matrix:
       matrix:
         sanitizer: [ADDRESS, THREAD, UNDEFINED]
         sanitizer: [ADDRESS, THREAD, UNDEFINED]
         build_type: [Debug, Release]
         build_type: [Debug, Release]
-        accelerate: [ON, OFF]
 
 
     steps:
     steps:
       - name: Clone
       - name: Clone
@@ -99,7 +98,7 @@ jobs:
         run: |
         run: |
           mkdir build
           mkdir build
           cd build
           cd build
-          cmake .. -DLLAMA_SANITIZE_${{ matrix.sanitizer }}=ON -DCMAKE_BUILD_TYPE=${{ matrix.build_type }} -DLLAMA_ACCELERATE=${{ matrix.accelerate }}
+          cmake .. -DLLAMA_SANITIZE_${{ matrix.sanitizer }}=ON -DCMAKE_BUILD_TYPE=${{ matrix.build_type }}
           cmake --build . --config ${{ matrix.build_type }}
           cmake --build . --config ${{ matrix.build_type }}
 
 
       - name: Test
       - name: Test