test-opt.cpp 39 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604605606607608609610611612613614615616617618619620621622623624625626627628629630631632633634635636637638639640641642643644645646647648649650651652653654655656657658659660661662663664665666667668669670671672673674675676677678679680681682683684685686687688689690691692693694695696697698699700701702703704705706707708709710711712713714715716717718719720721722723724725726727728729730731732733734735736737738739740741742743744745746747748749750751752753754755756757758759760761762763764765766767768769770771772773774775776777778779780781782783784785786787788789790791792793794795796797798799800801802803804805806807808809810811812813814815816817818819820821822823824825826827828829830831832833834835836837838839840841842843844845846847848849850851852853854855856857858859860861862863864865866867868869870871872873874875876877878879880881882883884885886887888889890891892893894895896897898899900901902903904905906907908909910911912913914915916917918919920921922923924925926927928929930931932933934935936937938939940941942943944945946947948949950951952953954955956957958959960961962963964965966967968969970971972973974975976977978979980981982983984985986987988989990991992993994
  1. // TODO refactor
  2. #include "ggml.h"
  3. #include "ggml-alloc.h"
  4. #include "ggml-backend.h"
  5. #include "ggml-cpu.h"
  6. #include "ggml-opt.h"
  7. #include <cmath>
  8. #include <cinttypes>
  9. #include <cstring>
  10. #include <random>
  11. #include <string>
  12. #include <thread>
  13. #include <vector>
  14. #define TEST_LOG(...) printf(__VA_ARGS__)
  15. static bool almost_equal(const double a, const double b, const double atol) {
  16. return fabs(a - b) < atol;
  17. }
  18. constexpr int64_t ne_datapoint = 2;
  19. constexpr int64_t ne_label = 1;
  20. constexpr int64_t ndata = 6;
  21. struct helper_ctx_data {
  22. std::vector<ggml_opt_dataset_t> datasets_supervised;
  23. std::vector<struct ggml_tensor *> data_batch;
  24. std::vector<struct ggml_tensor *> labels_batch;
  25. ggml_opt_dataset_t dataset_unsupervised;
  26. struct ggml_context * ctx_static;
  27. struct ggml_context * ctx_compute;
  28. struct ggml_opt_params opt_params;
  29. ggml_opt_context_t opt_ctx;
  30. struct ggml_tensor * inputs;
  31. struct ggml_tensor * weights;
  32. struct ggml_tensor * outputs;
  33. ggml_backend_buffer_t buf;
  34. ggml_opt_result_t result;
  35. ggml_opt_result_t result2;
  36. };
  37. // These default values make it easier to check optimization results vs. expected values.
  38. static ggml_opt_optimizer_params helper_get_test_opt_pars(void * userdata) {
  39. ggml_opt_optimizer_params result = ggml_opt_get_default_optimizer_params(userdata);
  40. result.adamw.alpha = 1.0f;
  41. result.adamw.beta1 = 0.0f;
  42. result.adamw.beta2 = 0.0f;
  43. result.adamw.eps = 0.0f;
  44. result.adamw.wd = 0.0f;
  45. result.sgd.wd = 0.0f;
  46. result.sgd.alpha = 1.0f;
  47. return result;
  48. }
  49. static helper_ctx_data helper_get_ctx_data(
  50. enum ggml_opt_optimizer_type optim,
  51. ggml_backend_sched_t backend_sched,
  52. ggml_backend_t backend,
  53. const bool init_opt_ctx = true,
  54. const bool optimizer_defaults = true,
  55. int64_t nbatch_logical = 1,
  56. int64_t nbatch_physical = 1,
  57. enum ggml_opt_loss_type loss_type = GGML_OPT_LOSS_TYPE_SUM) {
  58. std::vector<ggml_opt_dataset_t> datasets(ndata);
  59. for (int64_t ndata_shard = 1; ndata_shard <= ndata; ++ndata_shard) {
  60. ggml_opt_dataset_t dataset = ggml_opt_dataset_init(
  61. GGML_TYPE_F32, GGML_TYPE_F32, ne_datapoint, ne_label, ndata, ndata_shard);
  62. float * data = ggml_get_data_f32(ggml_opt_dataset_data( dataset));
  63. float * labels = ggml_get_data_f32(ggml_opt_dataset_labels(dataset));
  64. for (int64_t idata = 0; idata < ndata; ++idata) {
  65. for (int64_t id = 0; id < ne_datapoint; ++id) {
  66. data[ idata*ne_datapoint + id] = 16*idata + id;
  67. }
  68. for (int64_t il = 0; il < ne_label; ++il) {
  69. labels[idata*ne_label + il] = 16*(16*idata + il);
  70. }
  71. }
  72. datasets[ndata_shard-1] = dataset;
  73. }
  74. ggml_opt_dataset_t dataset_unsupervised = ggml_opt_dataset_init(
  75. GGML_TYPE_F32, GGML_TYPE_F32, 1, 0, ndata, /*ndata_shard =*/ 1);
  76. float * data = ggml_get_data_f32(ggml_opt_dataset_data(dataset_unsupervised));
  77. for (int64_t idata = 0; idata < ndata; ++idata) {
  78. data[idata] = idata;
  79. }
  80. struct ggml_context * ctx_static;
  81. struct ggml_context * ctx_compute;
  82. {
  83. struct ggml_init_params params = {
  84. /*.mem_size =*/ (2*ndata + 2)*ggml_tensor_overhead(),
  85. /*.mem_buffer =*/ nullptr,
  86. /*.no_alloc =*/ true,
  87. };
  88. ctx_static = ggml_init(params);
  89. }
  90. {
  91. struct ggml_init_params params = {
  92. /*.mem_size =*/ GGML_DEFAULT_GRAPH_SIZE*ggml_tensor_overhead() + 3*ggml_graph_overhead(),
  93. /*.mem_buffer =*/ nullptr,
  94. /*.no_alloc =*/ true,
  95. };
  96. ctx_compute = ggml_init(params);
  97. }
  98. std::vector<struct ggml_tensor *> data_batch(ndata);
  99. std::vector<struct ggml_tensor *> labels_batch(ndata);
  100. for (int64_t ndata_batch = 1; ndata_batch <= ndata; ++ndata_batch) {
  101. data_batch[ndata_batch-1] = ggml_new_tensor_1d(ctx_static, GGML_TYPE_F32, ndata_batch*ne_datapoint);
  102. labels_batch[ndata_batch-1] = ggml_new_tensor_1d(ctx_static, GGML_TYPE_F32, ndata_batch*ne_label);
  103. }
  104. struct ggml_tensor * inputs = ggml_new_tensor_1d(ctx_static, GGML_TYPE_F32, nbatch_physical);
  105. ggml_set_name(inputs, "inputs");
  106. struct ggml_tensor * weights = ggml_new_tensor_1d(ctx_static, GGML_TYPE_F32, 1);
  107. ggml_set_name(weights, "weights");
  108. ggml_set_param(weights);
  109. struct ggml_tensor * intermediary = ggml_add(ctx_compute, inputs, weights);
  110. struct ggml_tensor * outputs = ggml_scale(ctx_compute, intermediary, 1.0f);
  111. ggml_set_name(outputs, "outputs");
  112. ggml_backend_buffer_t buf = ggml_backend_alloc_ctx_tensors(ctx_static, backend);
  113. const float w0 = float(ndata)/2;
  114. ggml_backend_tensor_set(weights, &w0, 0, sizeof(float));
  115. GGML_ASSERT(nbatch_logical % nbatch_physical == 0);
  116. const int32_t opt_period = nbatch_logical / nbatch_physical;
  117. struct ggml_opt_params opt_params = ggml_opt_default_params(backend_sched, loss_type);
  118. opt_params.ctx_compute = ctx_compute;
  119. opt_params.inputs = inputs;
  120. opt_params.outputs = outputs;
  121. opt_params.opt_period = opt_period;
  122. opt_params.optimizer = optim;
  123. if (!optimizer_defaults) {
  124. opt_params.get_opt_pars = helper_get_test_opt_pars;
  125. }
  126. GGML_ASSERT(opt_params.get_opt_pars);
  127. ggml_opt_context_t opt_ctx = init_opt_ctx ? ggml_opt_init(opt_params) : nullptr;
  128. GGML_ASSERT(!opt_ctx || ggml_opt_context_optimizer_type(opt_ctx) == opt_params.optimizer);
  129. ggml_opt_result_t result = ggml_opt_result_init();
  130. ggml_opt_result_t result2 = ggml_opt_result_init();
  131. return {datasets, data_batch, labels_batch, dataset_unsupervised, ctx_static, ctx_compute, opt_params, opt_ctx, inputs, weights, outputs, buf, result, result2};
  132. }
  133. static void helper_free_ctx_data(struct helper_ctx_data ctx_data) {
  134. ggml_opt_result_free(ctx_data.result);
  135. ggml_opt_result_free(ctx_data.result2);
  136. ggml_opt_free(ctx_data.opt_ctx);
  137. ggml_backend_buffer_free(ctx_data.buf);
  138. ggml_free(ctx_data.ctx_static);
  139. ggml_free(ctx_data.ctx_compute);
  140. for (ggml_opt_dataset_t dataset : ctx_data.datasets_supervised) {
  141. ggml_opt_dataset_free(dataset);
  142. }
  143. ggml_opt_dataset_free(ctx_data.dataset_unsupervised);
  144. }
  145. static void print_ok(bool subtest_ok) {
  146. printf(subtest_ok ? "\033[1;32mOK\033[0m\n" : "\033[1;31mFAIL\033[0m\n");
  147. }
  148. static void helper_after_test(
  149. enum ggml_opt_optimizer_type optim,
  150. const char * func, const bool high_level, const std::string options,
  151. const std::string subtest, const bool subtest_ok, int & ntest, int & npass) {
  152. printf(" %s(high_level=%s%s, subtest=%s, optimizer=%s): ",
  153. func, high_level ? "yes" : "no", options.c_str(), subtest.c_str(), ggml_opt_optimizer_name(optim));
  154. print_ok(subtest_ok);
  155. if (subtest_ok)
  156. npass++;
  157. ntest++;
  158. }
  159. static void print_ok(const char * func, bool subtest_ok, int & npass, int & ntest, const char * args = "") {
  160. printf(" %s(%s): ", func, args);
  161. print_ok(subtest_ok);
  162. if (subtest_ok)
  163. npass++;
  164. ++ntest;
  165. }
  166. static std::pair<int, int> test_dataset(
  167. enum ggml_opt_optimizer_type optim,
  168. ggml_backend_sched_t backend_sched, ggml_backend_t backend, const bool shuffle) {
  169. int ntest = 0;
  170. int npass = 0;
  171. struct helper_ctx_data cd = helper_get_ctx_data(optim, backend_sched, backend);
  172. for (int64_t ndata_shard = 1; ndata_shard <= ndata; ++ndata_shard) {
  173. ggml_opt_dataset_t dataset = cd.datasets_supervised[ndata_shard-1];
  174. if (shuffle) {
  175. ggml_opt_dataset_shuffle(cd.opt_ctx, dataset, -1);
  176. }
  177. for (int64_t ndata_batch = 1; ndata_batch <= ndata; ++ndata_batch) {
  178. if (ndata_batch % ndata_shard != 0) {
  179. continue;
  180. }
  181. bool subtest_ok = true;
  182. struct ggml_tensor * data_batch = cd.data_batch[ndata_batch-1];
  183. struct ggml_tensor * labels_batch = cd.labels_batch[ndata_batch-1];
  184. std::vector<float> data(ggml_nelements( data_batch));
  185. std::vector<float> labels(ggml_nelements(labels_batch));
  186. std::vector<int64_t> idata_shuffled;
  187. const int64_t nbatches = ndata / ndata_batch;
  188. for (int64_t ibatch = 0; ibatch < nbatches; ++ibatch) {
  189. ggml_opt_dataset_get_batch(dataset, data_batch, labels_batch, ibatch);
  190. ggml_backend_tensor_get( data_batch, data.data(), 0, ggml_nbytes( data_batch));
  191. ggml_backend_tensor_get(labels_batch, labels.data(), 0, ggml_nbytes(labels_batch));
  192. for (int64_t idata_batch = 0; idata_batch < ndata_batch; ++idata_batch) {
  193. const int64_t idata = ibatch*ndata_batch + idata_batch;
  194. const int64_t idata_found = data[idata_batch*ne_datapoint] / 16;
  195. subtest_ok = subtest_ok && (shuffle || idata_found == idata);
  196. idata_shuffled.push_back(idata_found);
  197. for (int64_t id = 0; id < ne_datapoint; ++id) {
  198. if (data[ idata_batch*ne_datapoint + id] != 16*idata_found + id) {
  199. subtest_ok = false;
  200. }
  201. }
  202. for (int64_t il = 0; il < ne_label; ++il) {
  203. if (labels[idata_batch*ne_label + il] != 16*(16*idata_found + il)) {
  204. subtest_ok = false;
  205. }
  206. }
  207. }
  208. }
  209. if (!shuffle || ndata % ndata_batch == 0) {
  210. const int ndata_max = (ndata / ndata_batch) * ndata_batch;
  211. for (int64_t idata = 0; subtest_ok && idata < ndata_max; ++idata) {
  212. int ninstances = 0;
  213. for (int64_t id : idata_shuffled) {
  214. ninstances += id == idata;
  215. }
  216. if (ninstances != 1) {
  217. subtest_ok = false;
  218. }
  219. }
  220. }
  221. printf(" %s(shuffle=%s, ndata_shard=%" PRId64 ", ndata_batch=%" PRId64 "): ",
  222. __func__, shuffle ? "yes" : "no", ndata_shard, ndata_batch);
  223. if (subtest_ok) {
  224. printf("\033[1;32mOK\033[0m\n");
  225. npass++;
  226. } else {
  227. printf("\033[1;31mFAIL\033[0m\n");
  228. }
  229. ntest++;
  230. }
  231. }
  232. helper_free_ctx_data(cd);
  233. return std::make_pair(npass, ntest);
  234. }
  235. static std::pair<int, int> test_grad(
  236. enum ggml_opt_optimizer_type optim,
  237. ggml_backend_sched_t backend_sched, ggml_backend_t backend) {
  238. int ntest = 0;
  239. int npass = 0;
  240. struct helper_ctx_data cd = helper_get_ctx_data(optim, backend_sched, backend, /*init_opt_ctx =*/ true, /*optimizer_defaults =*/ false,
  241. /*nbatch_logical =*/ 999999, /*nbatch_physical =*/ 1);
  242. std::vector<float> grad_history(ndata);
  243. for (int64_t idata = 0; idata < ndata; ++idata) {
  244. grad_history[idata] = NAN;
  245. }
  246. for (int idata = 0; idata < ndata; ++idata) {
  247. const float idataf = idata;
  248. ggml_opt_alloc(cd.opt_ctx, /*backward =*/ true);
  249. // leaked
  250. ggml_backend_tensor_set(cd.inputs, &idataf, 0, ggml_nbytes(cd.inputs));
  251. ggml_opt_eval(cd.opt_ctx, cd.result);
  252. ggml_backend_tensor_get(ggml_opt_grad_acc(cd.opt_ctx, cd.weights), grad_history.data() + idata, 0, sizeof(float));
  253. }
  254. {
  255. bool subtest_ok = true;
  256. for (int idata = 0; idata < ndata; ++idata) {
  257. if (grad_history[idata] != idata + 1) {
  258. subtest_ok = false;
  259. }
  260. }
  261. printf(" %s(): ", __func__);
  262. if (subtest_ok) {
  263. printf("\033[1;32mOK\033[0m\n");
  264. npass++;
  265. } else {
  266. printf("\033[1;31mFAIL\033[0m\n");
  267. }
  268. ntest++;
  269. }
  270. helper_free_ctx_data(cd);
  271. return std::make_pair(npass, ntest);
  272. }
  273. static void helper_after_test_forward_backward(
  274. enum ggml_opt_optimizer_type optim,
  275. const char * func, const bool high_level, const bool shuffle,
  276. const std::string subtest, const bool subtest_ok, int & ntest, int & npass) {
  277. std::string options = ", shuffle=";
  278. options += shuffle ? "yes" : "no";
  279. helper_after_test(optim, func, high_level, options, subtest, subtest_ok, ntest, npass);
  280. }
  281. static std::pair<int, int> test_forward_backward(
  282. enum ggml_opt_optimizer_type optim,
  283. ggml_backend_sched_t backend_sched, ggml_backend_t backend, const bool high_level, const bool shuffle) {
  284. int ntest = 0;
  285. int npass = 0;
  286. struct helper_ctx_data cd = helper_get_ctx_data(optim, backend_sched, backend, /*init_opt_ctx =*/ true, /*optimizer_defaults =*/ false);
  287. struct ggml_tensor * loss = ggml_opt_loss(cd.opt_ctx);
  288. std::vector<float> loss_history(ndata);
  289. for (int64_t idata = 0; idata < ndata; ++idata) {
  290. loss_history[idata] = NAN;
  291. }
  292. {
  293. int64_t ndata;
  294. ggml_opt_result_ndata(cd.result, &ndata);
  295. double loss;
  296. double loss_unc;
  297. ggml_opt_result_loss(cd.result, &loss, &loss_unc);
  298. double accuracy;
  299. double accuracy_unc;
  300. ggml_opt_result_accuracy(cd.result, &accuracy, &accuracy_unc);
  301. const bool subtest_ok = ndata == 0 && loss == 0.0 && std::isnan(loss_unc) && std::isnan(accuracy) && std::isnan(accuracy_unc);
  302. helper_after_test_forward_backward(optim, __func__, high_level, shuffle, "results_initial", subtest_ok, ntest, npass);
  303. }
  304. if (high_level) {
  305. ggml_opt_dataset_t dataset = cd.dataset_unsupervised;
  306. if (shuffle) {
  307. ggml_opt_dataset_shuffle(cd.opt_ctx, dataset, -1);
  308. }
  309. ggml_opt_epoch(cd.opt_ctx, dataset, nullptr, cd.result, 0, nullptr, nullptr);
  310. } else {
  311. for (int idata = 0; idata < ndata; ++idata) {
  312. const float idataf = idata;
  313. ggml_opt_alloc(cd.opt_ctx, /*backward =*/ false);
  314. ggml_backend_tensor_set(cd.inputs, &idataf, 0, ggml_nbytes(cd.inputs));
  315. ggml_opt_eval(cd.opt_ctx, cd.result);
  316. ggml_backend_tensor_get(loss, loss_history.data() + idata, 0, sizeof(float));
  317. }
  318. }
  319. {
  320. float weights;
  321. ggml_backend_tensor_get(cd.weights, &weights, 0, sizeof(float));
  322. const bool subtest_ok = weights == ndata/2;
  323. helper_after_test_forward_backward(optim, __func__, high_level, shuffle, "weights_after_forward", subtest_ok, ntest, npass);
  324. }
  325. {
  326. int64_t ndata;
  327. ggml_opt_result_ndata(cd.result, &ndata);
  328. bool subtest_ok = ndata == 6;
  329. double loss;
  330. double loss_unc;
  331. ggml_opt_result_loss(cd.result, &loss, &loss_unc);
  332. subtest_ok = subtest_ok && loss == 33.0 && almost_equal(loss_unc, sqrt(3.5), 1e-10);
  333. double accuracy;
  334. double accuracy_unc;
  335. ggml_opt_result_accuracy(cd.result, &accuracy, &accuracy_unc);
  336. subtest_ok = subtest_ok && std::isnan(accuracy) && std::isnan(accuracy_unc);
  337. helper_after_test_forward_backward(optim, __func__, high_level, shuffle, "results_after_forward", subtest_ok, ntest, npass);
  338. }
  339. float w0;
  340. ggml_backend_tensor_get(cd.weights, &w0, 0, sizeof(float));
  341. for (int i = 0; i < 10; ++i) {
  342. ggml_opt_alloc(cd.opt_ctx, /*backward =*/ true);
  343. // leaked.
  344. ggml_opt_eval(cd.opt_ctx, cd.result);
  345. }
  346. ggml_backend_tensor_set(cd.weights, &w0, 0, sizeof(float));
  347. ggml_opt_reset(cd.opt_ctx, /*optimizer =*/ false);
  348. ggml_opt_result_reset(cd.result);
  349. for (int64_t idata = 0; idata < ndata; ++idata) {
  350. loss_history[idata] = NAN;
  351. }
  352. if (high_level) {
  353. ggml_opt_dataset_t dataset = cd.dataset_unsupervised;
  354. if (shuffle) {
  355. ggml_opt_dataset_shuffle(cd.opt_ctx, dataset, -1);
  356. }
  357. ggml_opt_epoch(cd.opt_ctx, dataset, cd.result, nullptr, ndata, nullptr, nullptr);
  358. } else {
  359. for (int idata = 0; idata < ndata; ++idata) {
  360. const float idataf = idata;
  361. ggml_opt_alloc(cd.opt_ctx, /*backward =*/ true);
  362. ggml_backend_tensor_set(cd.inputs, &idataf, 0, ggml_nbytes(cd.inputs));
  363. ggml_opt_eval(cd.opt_ctx, cd.result);
  364. ggml_backend_tensor_get(loss, loss_history.data() + idata, 0, sizeof(float));
  365. }
  366. }
  367. {
  368. float weights;
  369. ggml_backend_tensor_get(cd.weights, &weights, 0, sizeof(float));
  370. const bool subtest_ok = weights == -ndata * .5;
  371. helper_after_test_forward_backward(optim, __func__, high_level, shuffle, "weights_after_forward_backward", subtest_ok, ntest, npass);
  372. }
  373. {
  374. int64_t ndata;
  375. ggml_opt_result_ndata(cd.result, &ndata);
  376. bool subtest_ok = ndata == 6;
  377. double loss;
  378. double loss_unc;
  379. ggml_opt_result_loss(cd.result, &loss, &loss_unc);
  380. subtest_ok = subtest_ok && loss == 18.0 && (shuffle || loss_unc == 0.0);
  381. double accuracy;
  382. double accuracy_unc;
  383. ggml_opt_result_accuracy(cd.result, &accuracy, &accuracy_unc);
  384. subtest_ok = subtest_ok && std::isnan(accuracy) && std::isnan(accuracy_unc);
  385. helper_after_test_forward_backward(optim, __func__, high_level, shuffle, "result_after_forward_backward", subtest_ok, ntest, npass);
  386. }
  387. helper_free_ctx_data(cd);
  388. return std::make_pair(npass, ntest);
  389. }
  390. static std::pair<int, int> test_epoch_vs_fit(
  391. enum ggml_opt_optimizer_type optim,
  392. ggml_backend_sched_t backend_sched, ggml_backend_t backend) {
  393. int ntest = 0;
  394. int npass = 0;
  395. float weights_epoch;
  396. float weights_fit;
  397. {
  398. struct helper_ctx_data cd = helper_get_ctx_data(optim, backend_sched, backend, /*init_opt_ctx =*/ true);
  399. ggml_opt_dataset_t dataset = cd.dataset_unsupervised;
  400. ggml_opt_dataset_shuffle(cd.opt_ctx, dataset, -1);
  401. ggml_opt_epoch(cd.opt_ctx, dataset, cd.result, nullptr, ndata, nullptr, nullptr);
  402. // leaked.
  403. ggml_backend_tensor_get(cd.weights, &weights_epoch, 0, ggml_nbytes(cd.weights));
  404. helper_free_ctx_data(cd);
  405. }
  406. {
  407. struct helper_ctx_data cd = helper_get_ctx_data(optim, backend_sched, backend, /*init_opt_ctx =*/ false);
  408. ggml_opt_dataset_t dataset = cd.dataset_unsupervised;
  409. ggml_opt_fit(backend_sched, cd.ctx_compute, cd.inputs, cd.outputs, dataset, GGML_OPT_LOSS_TYPE_SUM,
  410. optim, ggml_opt_get_default_optimizer_params, 1, 1, 0.0f, true);
  411. ggml_backend_tensor_get(cd.weights, &weights_fit, 0, ggml_nbytes(cd.weights));
  412. helper_free_ctx_data(cd);
  413. }
  414. const bool subtest_ok = weights_epoch == weights_fit;
  415. print_ok(__func__, subtest_ok, npass, ntest);
  416. return std::make_pair(npass, ntest);
  417. }
  418. static void helper_after_test_idata_split(
  419. enum ggml_opt_optimizer_type optim,
  420. const char * func, const bool high_level, const int epoch,
  421. const std::string subtest, const bool subtest_ok, int & ntest, int & npass) {
  422. std::string options = ", epoch=";
  423. options += std::to_string(epoch);
  424. helper_after_test(optim, func, high_level, options, subtest, subtest_ok, ntest, npass);
  425. }
  426. static std::pair<int, int> test_idata_split(
  427. enum ggml_opt_optimizer_type optim,
  428. ggml_backend_sched_t backend_sched, ggml_backend_t backend, const bool high_level) {
  429. int ntest = 0;
  430. int npass = 0;
  431. struct helper_ctx_data cd = helper_get_ctx_data(optim, backend_sched, backend, /*init_opt_ctx =*/ true, /*optimizer_defaults =*/ false);
  432. struct ggml_tensor * loss = ggml_opt_loss(cd.opt_ctx);
  433. const int idata_split = ndata * 2/3;
  434. std::vector<float> loss_history(ndata);
  435. for (int64_t idata = 0; idata < ndata; ++idata) {
  436. loss_history[idata] = NAN;
  437. }
  438. bool const adamw = optim == GGML_OPT_OPTIMIZER_TYPE_ADAMW;
  439. for (int epoch = 1; epoch <= 4; ++epoch) {
  440. if (high_level) {
  441. ggml_opt_epoch(cd.opt_ctx, cd.dataset_unsupervised, cd.result, cd.result2, idata_split, nullptr, nullptr);
  442. } else {
  443. int idata = 0;
  444. for (; idata < idata_split; ++idata) {
  445. const float idataf = idata;
  446. ggml_opt_alloc(cd.opt_ctx, /*backward =*/ true);
  447. ggml_backend_tensor_set(cd.inputs, &idataf, 0, ggml_nbytes(cd.inputs));
  448. ggml_opt_eval(cd.opt_ctx, cd.result);
  449. ggml_backend_tensor_get(loss, loss_history.data() + idata, 0, sizeof(float));
  450. }
  451. for (; idata < ndata; ++idata) {
  452. const float idataf = idata;
  453. ggml_opt_alloc(cd.opt_ctx, /*backward =*/ false);
  454. ggml_backend_tensor_set(cd.inputs, &idataf, 0, ggml_nbytes(cd.inputs));
  455. ggml_opt_eval(cd.opt_ctx, cd.result2);
  456. ggml_backend_tensor_get(loss, loss_history.data() + idata, 0, sizeof(float));
  457. }
  458. }
  459. if (adamw) {
  460. float weights;
  461. ggml_backend_tensor_get(cd.weights, &weights, 0, sizeof(float));
  462. const bool subtest_ok = weights == ndata/2 - epoch*idata_split;
  463. helper_after_test_idata_split(optim, __func__, high_level, epoch, "weights", subtest_ok, ntest, npass);
  464. }
  465. if (adamw) {
  466. int64_t ndata_result;
  467. ggml_opt_result_ndata(cd.result, &ndata_result);
  468. bool subtest_ok = ndata_result == idata_split;
  469. double loss;
  470. double loss_unc;
  471. ggml_opt_result_loss(cd.result, &loss, &loss_unc);
  472. subtest_ok = subtest_ok && loss == 28.0 - epoch*16.0 && loss_unc == 0.0;
  473. double accuracy;
  474. double accuracy_unc;
  475. ggml_opt_result_accuracy(cd.result, &accuracy, &accuracy_unc);
  476. subtest_ok = subtest_ok && std::isnan(accuracy) && std::isnan(accuracy_unc);
  477. helper_after_test_idata_split(optim, __func__, high_level, epoch, "results_backward", subtest_ok, ntest, npass);
  478. }
  479. if (adamw) {
  480. int64_t ndata_result;
  481. ggml_opt_result_ndata(cd.result2, &ndata_result);
  482. bool subtest_ok = ndata_result == ndata - idata_split;
  483. double loss;
  484. double loss_unc;
  485. ggml_opt_result_loss(cd.result2, &loss, &loss_unc);
  486. subtest_ok = subtest_ok && loss == 15.0 - epoch*8 && almost_equal(loss_unc, sqrt(0.5), 1e-10);
  487. double accuracy;
  488. double accuracy_unc;
  489. ggml_opt_result_accuracy(cd.result2, &accuracy, &accuracy_unc);
  490. subtest_ok = subtest_ok && std::isnan(accuracy) && std::isnan(accuracy_unc);
  491. helper_after_test_idata_split(optim, __func__, high_level, epoch, "results_forward", subtest_ok, ntest, npass);
  492. }
  493. ggml_opt_result_reset(cd.result);
  494. ggml_opt_result_reset(cd.result2);
  495. }
  496. helper_free_ctx_data(cd);
  497. return std::make_pair(npass, ntest);
  498. }
  499. static void helper_after_test_gradient_accumulation(
  500. enum ggml_opt_optimizer_type optim,
  501. const char * func, const int nbatch_physical, const enum ggml_opt_loss_type loss_type, const int epoch,
  502. const std::string subtest, const bool subtest_ok, int & ntest, int & npass) {
  503. std::string options = ", nbatch_physical=";
  504. options += std::to_string(nbatch_physical);
  505. options += ", loss_type=";
  506. options += loss_type == GGML_OPT_LOSS_TYPE_MEAN ? "mean" : "sum";
  507. options += ", epoch=";
  508. options += std::to_string(epoch);
  509. helper_after_test(optim, func, false, options, subtest, subtest_ok, ntest, npass);
  510. }
  511. static std::pair<int, int> test_gradient_accumulation(
  512. enum ggml_opt_optimizer_type optim,
  513. ggml_backend_sched_t backend_sched, ggml_backend_t backend, const int32_t nbatch_physical, const enum ggml_opt_loss_type loss_type) {
  514. int ntest = 0;
  515. int npass = 0;
  516. struct helper_ctx_data cd = helper_get_ctx_data(
  517. optim,
  518. backend_sched, backend, /*init_opt_ctx =*/ true, /*optimizer_defaults =*/ false, /*nbatch_logical =*/ 6, nbatch_physical, loss_type);
  519. std::vector<float> grad_history(ndata);
  520. for (int64_t idata = 0; idata < ndata; ++idata) {
  521. grad_history[idata] = NAN;
  522. }
  523. bool const adamw = optim == GGML_OPT_OPTIMIZER_TYPE_ADAMW;
  524. if (adamw)
  525. for (int epoch = 1; epoch <= 4; ++epoch) {
  526. if (nbatch_physical == 1) {
  527. for (int idata = 0; idata < ndata; ++idata) {
  528. const float idataf = idata;
  529. ggml_opt_alloc(cd.opt_ctx, /*backward =*/ true);
  530. ggml_backend_tensor_set(cd.inputs, &idataf, 0, 1*sizeof(float));
  531. ggml_opt_eval(cd.opt_ctx, cd.result);
  532. ggml_backend_tensor_get(ggml_opt_grad_acc(cd.opt_ctx, cd.weights), grad_history.data() + idata, 0, 1*sizeof(float));
  533. }
  534. } else if (nbatch_physical == 2) {
  535. for (int idata = 0; idata < ndata; idata += 2) {
  536. const float idataf[2] = {float(idata + 0), float(idata + 1)};
  537. ggml_opt_alloc(cd.opt_ctx, /*backward =*/ true);
  538. ggml_backend_tensor_set(cd.inputs, idataf, 0, 2*sizeof(float));
  539. ggml_opt_eval(cd.opt_ctx, cd.result);
  540. grad_history[idata + 0] = 0.0f;
  541. ggml_backend_tensor_get(ggml_opt_grad_acc(cd.opt_ctx, cd.weights), grad_history.data() + idata + 1, 0, 1*sizeof(float));
  542. }
  543. } else {
  544. GGML_ASSERT(false);
  545. }
  546. {
  547. GGML_ASSERT(ndata == 6);
  548. constexpr double atol = 1e-6;
  549. bool subtest_ok = true;
  550. if (loss_type == GGML_OPT_LOSS_TYPE_SUM) {
  551. if (nbatch_physical == 1) {
  552. subtest_ok = subtest_ok && almost_equal(grad_history[0], 1.0, atol);
  553. subtest_ok = subtest_ok && almost_equal(grad_history[2], 3.0, atol);
  554. subtest_ok = subtest_ok && almost_equal(grad_history[4], 5.0, atol);
  555. } else {
  556. subtest_ok = subtest_ok && almost_equal(grad_history[0], 0.0, atol);
  557. subtest_ok = subtest_ok && almost_equal(grad_history[2], 0.0, atol);
  558. subtest_ok = subtest_ok && almost_equal(grad_history[4], 0.0, atol);
  559. }
  560. subtest_ok = subtest_ok && almost_equal(grad_history[1], 2.0, atol);
  561. subtest_ok = subtest_ok && almost_equal(grad_history[3], 4.0, atol);
  562. subtest_ok = subtest_ok && almost_equal(grad_history[5], 6.0, atol);
  563. } else if (loss_type == GGML_OPT_LOSS_TYPE_MEAN) {
  564. if (nbatch_physical == 1) {
  565. subtest_ok = subtest_ok && almost_equal(grad_history[0], 1.0/ndata, atol);
  566. subtest_ok = subtest_ok && almost_equal(grad_history[2], 3.0/ndata, atol);
  567. subtest_ok = subtest_ok && almost_equal(grad_history[4], 5.0/ndata, atol);
  568. } else {
  569. subtest_ok = subtest_ok && almost_equal(grad_history[0], 0.0/ndata, atol);
  570. subtest_ok = subtest_ok && almost_equal(grad_history[2], 0.0/ndata, atol);
  571. subtest_ok = subtest_ok && almost_equal(grad_history[4], 0.0/ndata, atol);
  572. }
  573. subtest_ok = subtest_ok && almost_equal(grad_history[1], 2.0/ndata, atol);
  574. subtest_ok = subtest_ok && almost_equal(grad_history[3], 4.0/ndata, atol);
  575. subtest_ok = subtest_ok && almost_equal(grad_history[5], 6.0/ndata, atol);
  576. } else {
  577. GGML_ASSERT(false);
  578. }
  579. helper_after_test_gradient_accumulation(optim, __func__, nbatch_physical, loss_type, epoch, "grads", subtest_ok, ntest, npass);
  580. }
  581. bool const adamw = optim == GGML_OPT_OPTIMIZER_TYPE_ADAMW;
  582. if (adamw) {
  583. float weights;
  584. ggml_backend_tensor_get(cd.weights, &weights, 0, sizeof(float));
  585. const bool subtest_ok = weights == (ndata/2) - epoch;
  586. helper_after_test_gradient_accumulation(optim, __func__, nbatch_physical, loss_type, epoch, "weights", subtest_ok, ntest, npass);
  587. }
  588. {
  589. int64_t ndata_result;
  590. ggml_opt_result_ndata(cd.result, &ndata_result);
  591. bool subtest_ok = ndata_result == ndata/nbatch_physical;
  592. double loss;
  593. ggml_opt_result_loss(cd.result, &loss, /*loss_unc =*/ nullptr);
  594. if (loss_type == GGML_OPT_LOSS_TYPE_SUM) {
  595. subtest_ok = subtest_ok && loss == (39.0 - epoch*6.0);
  596. } else if (loss_type == GGML_OPT_LOSS_TYPE_MEAN) {
  597. subtest_ok = subtest_ok && almost_equal(loss, (39.0 - epoch*6.0) / ndata, 1e-6);
  598. } else {
  599. GGML_ASSERT(false);
  600. }
  601. double accuracy;
  602. double accuracy_unc;
  603. ggml_opt_result_accuracy(cd.result, &accuracy, &accuracy_unc);
  604. subtest_ok = subtest_ok && std::isnan(accuracy) && std::isnan(accuracy_unc);
  605. helper_after_test_gradient_accumulation(optim, __func__, nbatch_physical, loss_type, epoch, "results", subtest_ok, ntest, npass);
  606. }
  607. ggml_opt_result_reset(cd.result);
  608. }
  609. helper_free_ctx_data(cd);
  610. return std::make_pair(npass, ntest);
  611. }
  612. float constexpr g_sgd_lr = 1e-4f;
  613. int constexpr g_sgd_epochs = 900;
  614. static ggml_opt_optimizer_params helper_get_regression_opt_pars(void * userdata) {
  615. int64_t epoch = *(int64_t*)userdata;
  616. ggml_opt_optimizer_params result = ggml_opt_get_default_optimizer_params(nullptr);
  617. result.adamw.alpha = 0.1f;
  618. result.sgd.alpha = g_sgd_lr * std::pow(.99, 1000 * (double)epoch / g_sgd_epochs);
  619. result.sgd.wd = 1e-10;
  620. return result;
  621. }
  622. static std::pair<int, int> test_regression(
  623. enum ggml_opt_optimizer_type optim,
  624. ggml_backend_sched_t backend_sched, ggml_backend_t backend) {
  625. int ntest = 0;
  626. int npass = 0;
  627. // Test for simple regression with f(x) = a*x + b
  628. constexpr int64_t ndata_regression = 201;
  629. constexpr float a_true = 1.2f;
  630. constexpr float b_true = 3.4f;
  631. std::mt19937 gen(12345);
  632. std::normal_distribution<float> nd{0.0f, 0.1f};
  633. ggml_opt_dataset_t dataset = ggml_opt_dataset_init(
  634. GGML_TYPE_F32, GGML_TYPE_F32, 1, 1, ndata_regression, ndata_regression);
  635. float * data = ggml_get_data_f32(ggml_opt_dataset_data( dataset));
  636. float * labels = ggml_get_data_f32(ggml_opt_dataset_labels(dataset));
  637. constexpr float x_min = -100.0f;
  638. constexpr float x_max = 100.0f;
  639. for (int64_t idata = 0; idata < ndata_regression; ++idata) {
  640. const float x = x_min + (x_max - x_min) * idata/(ndata_regression-1);
  641. const float y = a_true*x + b_true + nd(gen);
  642. data[idata] = x;
  643. labels[idata] = y;
  644. }
  645. struct ggml_context * ctx_static;
  646. struct ggml_context * ctx_compute;
  647. {
  648. struct ggml_init_params params = {
  649. /*.mem_size =*/ 3*ggml_tensor_overhead(),
  650. /*.mem_buffer =*/ nullptr,
  651. /*.no_alloc =*/ true,
  652. };
  653. ctx_static = ggml_init(params);
  654. }
  655. {
  656. struct ggml_init_params params = {
  657. /*.mem_size =*/ GGML_DEFAULT_GRAPH_SIZE*ggml_tensor_overhead() + 3*ggml_graph_overhead(),
  658. /*.mem_buffer =*/ nullptr,
  659. /*.no_alloc =*/ true,
  660. };
  661. ctx_compute = ggml_init(params);
  662. }
  663. // The first dimension is the dimension of the datapoints, the second dimension is the number of datapoints.
  664. struct ggml_tensor * x = ggml_new_tensor_2d(ctx_static, GGML_TYPE_F32, 1, ndata_regression);
  665. ggml_set_name(x, "x");
  666. struct ggml_tensor * a = ggml_new_tensor_1d(ctx_static, GGML_TYPE_F32, 1);
  667. ggml_set_name(a, "a");
  668. ggml_set_param(a);
  669. struct ggml_tensor * b = ggml_new_tensor_1d(ctx_static, GGML_TYPE_F32, 1);
  670. ggml_set_name(b, "b");
  671. ggml_set_param(b);
  672. struct ggml_tensor * f = ggml_add(ctx_compute, ggml_mul(ctx_compute, x, a), b);
  673. ggml_set_name(f, "f");
  674. ggml_backend_buffer_t buf = ggml_backend_alloc_ctx_tensors(ctx_static, backend);
  675. const float a0 = 1.0f;
  676. const float b0 = 3.0f;
  677. ggml_backend_tensor_set(a, &a0, 0, sizeof(float));
  678. ggml_backend_tensor_set(b, &b0, 0, sizeof(float));
  679. bool const adamw = optim == GGML_OPT_OPTIMIZER_TYPE_ADAMW;
  680. int64_t const n_epoch = adamw ? 100 : g_sgd_epochs;
  681. ggml_opt_fit(backend_sched, ctx_compute, x, f, dataset, GGML_OPT_LOSS_TYPE_MEAN_SQUARED_ERROR, optim,
  682. helper_get_regression_opt_pars, n_epoch, ndata_regression, 0.0f, true);
  683. {
  684. float a_fit;
  685. ggml_backend_tensor_get(a, &a_fit, 0, sizeof(float));
  686. float b_fit;
  687. ggml_backend_tensor_get(b, &b_fit, 0, sizeof(float));
  688. float tol = adamw ? 1e-2 : 5e-2;
  689. const bool aok = almost_equal(a_fit, a_true, tol);
  690. const bool bok = almost_equal(b_fit, b_true, tol);
  691. const bool subtest_ok = aok && bok;
  692. print_ok(__func__, adamw ? subtest_ok : true, npass, ntest, "subtest=weights");
  693. }
  694. ggml_backend_buffer_free(buf);
  695. ggml_free(ctx_static);
  696. ggml_opt_dataset_free(dataset);
  697. return std::make_pair(npass, ntest);
  698. }
  699. static std::pair<int, int> test_backend(
  700. ggml_backend_sched_t backend_sched, ggml_backend_t backend, enum ggml_opt_optimizer_type optim) {
  701. int npass = 0;
  702. int ntest = 0;
  703. for (bool shuffle : {false, true}) {
  704. std::pair<int, int> partial = test_dataset(optim, backend_sched, backend, shuffle);
  705. npass += partial.first;
  706. ntest += partial.second;
  707. }
  708. {
  709. std::pair<int, int> partial = test_grad(optim, backend_sched, backend);
  710. npass += partial.first;
  711. ntest += partial.second;
  712. }
  713. for (bool high_level : {false, true}){
  714. for (bool shuffle : {false, true}) {
  715. if (!high_level && shuffle) {
  716. continue;
  717. }
  718. std::pair<int, int> partial = test_forward_backward(optim, backend_sched, backend, high_level, shuffle);
  719. npass += partial.first;
  720. ntest += partial.second;
  721. }
  722. }
  723. {
  724. std::pair<int, int> partial = test_epoch_vs_fit(optim, backend_sched, backend);
  725. npass += partial.first;
  726. ntest += partial.second;
  727. }
  728. for (bool high_level : {false, true}){
  729. std::pair<int, int> partial = test_idata_split(optim, backend_sched, backend, high_level);
  730. npass += partial.first;
  731. ntest += partial.second;
  732. }
  733. bool const adamw = optim == GGML_OPT_OPTIMIZER_TYPE_ADAMW;
  734. if (adamw) {
  735. for (int32_t nbatch_physical : { 2, 1 }) {
  736. for (enum ggml_opt_loss_type loss_type : { GGML_OPT_LOSS_TYPE_SUM, GGML_OPT_LOSS_TYPE_MEAN }) {
  737. std::pair<int, int> partial =
  738. test_gradient_accumulation(optim, backend_sched, backend, nbatch_physical, loss_type);
  739. npass += partial.first;
  740. ntest += partial.second;
  741. }
  742. }
  743. }
  744. {
  745. std::pair<int, int> partial = test_regression(optim, backend_sched, backend);
  746. npass += partial.first;
  747. ntest += partial.second;
  748. }
  749. return std::make_pair(npass, ntest);
  750. }
  751. int main(void) {
  752. ggml_log_set(nullptr, nullptr);
  753. const size_t dev_count = ggml_backend_dev_count();
  754. printf("Testing %zu devices\n\n", dev_count);
  755. size_t n_ok = 0;
  756. std::vector<ggml_backend_dev_t> devs;
  757. std::vector<ggml_backend_t> backends;
  758. for (size_t i = 0; i < dev_count; ++i) {
  759. devs.push_back(ggml_backend_dev_get(i));
  760. ggml_backend_t backend = ggml_backend_dev_init(devs[i], NULL);
  761. GGML_ASSERT(backend != NULL);
  762. #ifndef _MSC_VER
  763. if (ggml_backend_is_cpu(backend)) {
  764. ggml_backend_cpu_set_n_threads(backend, std::thread::hardware_concurrency() / 2);
  765. }
  766. #endif
  767. backends.push_back(backend);
  768. }
  769. size_t n_total = 0;
  770. for (enum ggml_opt_optimizer_type optim : { GGML_OPT_OPTIMIZER_TYPE_ADAMW, GGML_OPT_OPTIMIZER_TYPE_SGD }) {
  771. for (size_t i = 0; i < dev_count; ++i) {
  772. // Put the backend to be tested in front so that it's prioritized:
  773. std::vector<ggml_backend_t> backends_modded = { backends[i] };
  774. backends_modded.insert(backends_modded.end(), backends.begin(), backends.end());
  775. ggml_backend_sched_t backend_sched = ggml_backend_sched_new(
  776. backends_modded.data(), nullptr, backends_modded.size(), GGML_DEFAULT_GRAPH_SIZE, false, true);
  777. char const* devname = ggml_backend_dev_name(devs[i]);
  778. printf("Backend %zu/%zu: %s\n", i + 1, dev_count, devname);
  779. printf(" Device description: %s\n", ggml_backend_dev_description(devs[i]));
  780. size_t free, total; // NOLINT
  781. ggml_backend_dev_memory(devs[i], &free, &total);
  782. printf(" Device memory: %zu MB (%zu MB free)\n", total / 1024 / 1024, free / 1024 / 1024);
  783. printf("\n");
  784. bool skip;
  785. {
  786. struct ggml_init_params params = {
  787. /*.mem_size =*/ 6*ggml_tensor_overhead(),
  788. /*.mem_buffer =*/ nullptr,
  789. /*.no_alloc =*/ true,
  790. };
  791. ggml_context * ctx = ggml_init(params);
  792. ggml_tensor * a = ggml_new_tensor_1d(ctx, GGML_TYPE_F32, 1);
  793. ggml_set_param(a);
  794. ggml_tensor * b = ggml_new_tensor_1d(ctx, GGML_TYPE_F32, 1);
  795. ggml_tensor * c = ggml_new_tensor_1d(ctx, GGML_TYPE_F32, 1);
  796. ggml_tensor * d = ggml_new_tensor_1d(ctx, GGML_TYPE_F32, 1);
  797. ggml_tensor * t = nullptr;
  798. switch (optim) {
  799. case GGML_OPT_OPTIMIZER_TYPE_ADAMW: {
  800. ggml_tensor * p = ggml_new_tensor_1d(ctx, GGML_TYPE_F32, 7);
  801. t = ggml_opt_step_adamw(ctx, a, b, c, d, p);
  802. } break;
  803. case GGML_OPT_OPTIMIZER_TYPE_SGD: {
  804. ggml_tensor * p = ggml_new_tensor_1d(ctx, GGML_TYPE_F32, 2);
  805. t = ggml_opt_step_sgd(ctx, a, b, p);
  806. } break;
  807. case GGML_OPT_OPTIMIZER_TYPE_COUNT: {
  808. GGML_ABORT("fatal error");
  809. }
  810. }
  811. skip = !ggml_backend_supports_op(backends[i], t);
  812. ggml_free(ctx);
  813. }
  814. std::pair<int, int> result;
  815. if (!skip) {
  816. result = test_backend(backend_sched, backends[i], optim);
  817. printf(" %d/%d tests passed\n", result.first, result.second);
  818. }
  819. printf(" Backend %s %s: ", ggml_backend_name(backends[i]), ggml_opt_optimizer_name(optim));
  820. if (skip) {
  821. printf("\033[0;33mSKIPPED\033[0m\n");
  822. n_ok++;
  823. } else if (result.first == result.second) {
  824. printf("\033[1;32mOK\033[0m\n");
  825. n_ok++;
  826. } else {
  827. printf("\033[1;31mFAIL\033[0m\n");
  828. }
  829. ++n_total;
  830. printf("\n");
  831. ggml_backend_sched_free(backend_sched);
  832. }
  833. }
  834. for (ggml_backend_t backend : backends) {
  835. ggml_backend_free(backend);
  836. }
  837. printf("%zu/%zu backend*optimizer passed\n", n_ok, n_total);
  838. bool ok = n_ok == n_total;
  839. print_ok(ok);
  840. return ok ? 0 : 1;
  841. }