test(admin-ui): Remove unused tests and DataService mock

The DataService mock is literally never used and is just a pain to maintain for absolutely zero benefit.

admin-ui/src/app/catalog/components/product-variants-wizard/product-variants-wizard.component.spec.ts

@@ -1,47 +0,0 @@
-import { async, ComponentFixture, TestBed } from '@angular/core/testing';
-import { FormsModule, ReactiveFormsModule } from '@angular/forms';
-
-import { TestingCommonModule } from '../../../../testing/testing-common.module';
-import { NotificationService } from '../../../core/providers/notification/notification.service';
-import { MockNotificationService } from '../../../core/providers/notification/notification.service.mock';
-import { AffixedInputComponent } from '../../../shared/components/affixed-input/affixed-input.component';
-import { ChipComponent } from '../../../shared/components/chip/chip.component';
-import { CurrencyInputComponent } from '../../../shared/components/currency-input/currency-input.component';
-import { SelectToggleComponent } from '../../../shared/components/select-toggle/select-toggle.component';
-import { BackgroundColorFromDirective } from '../../../shared/directives/background-color-from.directive';
-import { CreateOptionGroupFormComponent } from '../create-option-group-form/create-option-group-form.component';
-import { SelectOptionGroupComponent } from '../select-option-group/select-option-group.component';
-
-import { ProductVariantsWizardComponent } from './product-variants-wizard.component';
-
-describe('ProductVariantsWizardComponent', () => {
-    let component: ProductVariantsWizardComponent;
-    let fixture: ComponentFixture<ProductVariantsWizardComponent>;
-
-    beforeEach(async(() => {
-        TestBed.configureTestingModule({
-            imports: [TestingCommonModule, ReactiveFormsModule, FormsModule],
-            declarations: [
-                ProductVariantsWizardComponent,
-                SelectOptionGroupComponent,
-                CreateOptionGroupFormComponent,
-                SelectToggleComponent,
-                ChipComponent,
-                CurrencyInputComponent,
-                AffixedInputComponent,
-                BackgroundColorFromDirective,
-            ],
-            providers: [{ provide: NotificationService, useClass: MockNotificationService }],
-        }).compileComponents();
-    }));
-
-    beforeEach(() => {
-        fixture = TestBed.createComponent(ProductVariantsWizardComponent);
-        component = fixture.componentInstance;
-        fixture.detectChanges();
-    });
-
-    it('should create', () => {
-        expect(component).toBeTruthy();
-    });
-});

admin-ui/src/app/catalog/components/select-option-group/select-option-group.component.spec.ts

@@ -1,39 +0,0 @@
-import { async, ComponentFixture, TestBed } from '@angular/core/testing';
-import { ReactiveFormsModule } from '@angular/forms';
-
-import { TestingCommonModule } from '../../../../testing/testing-common.module';
-import { DataService } from '../../../data/providers/data.service';
-import { MockDataService } from '../../../data/providers/data.service.mock';
-import { ChipComponent } from '../../../shared/components/chip/chip.component';
-import { SelectToggleComponent } from '../../../shared/components/select-toggle/select-toggle.component';
-import { BackgroundColorFromDirective } from '../../../shared/directives/background-color-from.directive';
-
-import { SelectOptionGroupComponent } from './select-option-group.component';
-
-describe('SelectOptionGroupComponent', () => {
-    let component: SelectOptionGroupComponent;
-    let fixture: ComponentFixture<SelectOptionGroupComponent>;
-
-    beforeEach(async(() => {
-        TestBed.configureTestingModule({
-            imports: [ReactiveFormsModule, TestingCommonModule],
-            declarations: [
-                SelectOptionGroupComponent,
-                SelectToggleComponent,
-                ChipComponent,
-                BackgroundColorFromDirective,
-            ],
-            providers: [{ provide: DataService, useClass: MockDataService }],
-        }).compileComponents();
-    }));
-
-    beforeEach(() => {
-        fixture = TestBed.createComponent(SelectOptionGroupComponent);
-        component = fixture.componentInstance;
-        fixture.detectChanges();
-    });
-
-    it('should create', () => {
-        expect(component).toBeTruthy();
-    });
-});

admin-ui/src/app/data/providers/data.service.mock.ts

@@ -1,124 +0,0 @@
-import { of } from 'rxjs';
-
-import { QueryResult } from '../query-result';
-
-import { DataService } from './data.service';
-
-export type DataServiceSectionMock<T> = { [K in keyof T]: jasmine.Spy };
-
-export type DataServiceMock = { [K in keyof DataService]?: DataServiceSectionMock<DataService[K]> };
-
-export type MockQueryResult = { [K in keyof QueryResult<any>]: any };
-
-export function spyQueryResult(name: string): jasmine.Spy {
-    const mockQueryResult: MockQueryResult = {
-        ref: {},
-        stream$: of({}),
-        single$: of({}),
-        mapStream() {
-            return of({});
-        },
-        mapSingle() {
-            return of({});
-        },
-    };
-    return jasmine.createSpy(name).and.returnValue(mockQueryResult);
-}
-
-export function spyObservable(name: string, returnValue: any = {}): jasmine.Spy {
-    return jasmine.createSpy(name).and.returnValue(of(returnValue));
-}
-
-export class MockDataService implements DataServiceMock {
-    customer = {
-        getCustomerList: spyQueryResult('getCustomerList'),
-        getCustomer: spyQueryResult('getCustomer'),
-        createCustomer: spyObservable('createCustomer'),
-        updateCustomer: spyObservable('updateCustomer'),
-        updateCustomerAddress: spyObservable('updateCustomerAddress'),
-    };
-    promotion = {
-        getPromotions: spyQueryResult('getPromotions'),
-        getPromotion: spyQueryResult('getPromotion'),
-        getAdjustmentOperations: spyQueryResult('getAdjustmentOperations'),
-        createPromotion: spyObservable('createPromotion'),
-        updatePromotion: spyObservable('updatePromotion'),
-    };
-    administrator = {
-        getAdministrators: spyQueryResult('getAdministrators'),
-        getAdministrator: spyQueryResult('getAdministrator'),
-        createAdministrator: spyObservable('createAdministrator'),
-        updateAdministrator: spyObservable('updateAdministrator'),
-        getRoles: spyQueryResult('getRoles'),
-        getRole: spyQueryResult('getRole'),
-        createRole: spyObservable('createRole'),
-        updateRole: spyObservable('updateRole'),
-    };
-    client = {
-        startRequest: spyObservable('startRequest'),
-        completeRequest: spyObservable('completeRequest'),
-        getNetworkStatus: spyObservable('getNetworkStatus'),
-        loginSuccess: spyObservable('loginSuccess'),
-        logOut: spyObservable('logOut'),
-        userStatus: spyQueryResult('userStatus'),
-        uiState: spyQueryResult('uiState'),
-        setUiLanguage: spyObservable('setUiLanguage'),
-    };
-    order = {
-        getOrders: spyQueryResult('getOrders'),
-        getOrder: spyQueryResult('getOrder'),
-    };
-    product = {
-        getProducts: spyQueryResult('getProducts'),
-        getProduct: spyQueryResult('getProduct'),
-        createProduct: spyObservable('createProduct'),
-        updateProduct: spyObservable('updateProduct'),
-        updateProductVariants: spyObservable('updateProductVariants'),
-        createProductOptionGroups: spyObservable('createProductOptionGroups'),
-        addOptionGroupToProduct: spyObservable('addOptionGroupToProduct'),
-        removeOptionGroupFromProduct: spyObservable('removeOptionGroupFromProduct'),
-        getProductOptionGroups: spyQueryResult('getProductOptionGroups'),
-        generateProductVariants: spyObservable('generateProductVariants'),
-        applyFacetValuesToProductVariants: spyObservable('applyFacetValuesToProductVariants'),
-        getAssetList: spyQueryResult('getAssetList'),
-        createAssets: spyObservable('createAssets'),
-    };
-    auth = {
-        checkLoggedIn: spyObservable('checkLoggedIn'),
-        attemptLogin: spyObservable('attemptLogin'),
-        logOut: spyObservable('logOut'),
-    };
-    facet = {
-        getFacets: spyQueryResult('getFacets'),
-        getFacet: spyQueryResult('getFacet'),
-        createFacet: spyObservable('createFacet'),
-        updateFacet: spyObservable('updateFacet'),
-        createFacetValues: spyObservable('createFacetValues'),
-        updateFacetValues: spyObservable('updateFacetValues'),
-    };
-    settings = {
-        getCountries: spyQueryResult('getCountries'),
-        getCountry: spyQueryResult('getCountry'),
-        createCountry: spyObservable('createCountry'),
-        updateCountry: spyObservable('updateCountry'),
-        getZones: spyQueryResult('getZones'),
-        getZone: spyQueryResult('getZone'),
-        createZone: spyObservable('createZone'),
-        updateZone: spyObservable('updateZone'),
-        addMembersToZone: spyObservable('addMembersToZone'),
-        removeMembersFromZone: spyObservable('removeMembersFromZone'),
-        getTaxCategories: spyQueryResult('getTaxCategories'),
-        getTaxCategory: spyQueryResult('getTaxCategory'),
-        createTaxCategory: spyObservable('createTaxCategory'),
-        updateTaxCategory: spyObservable('updateTaxCategory'),
-        getTaxRates: spyQueryResult('getTaxRates'),
-        getTaxRate: spyQueryResult('getTaxRate'),
-        createTaxRate: spyObservable('createTaxRate'),
-        updateTaxRate: spyObservable('updateTaxRate'),
-        getChannels: spyQueryResult('getChannels'),
-        getChannel: spyQueryResult('getChannel'),
-        getActiveChannel: spyQueryResult('getActiveChannel'),
-        createChannel: spyObservable('createChannel'),
-        updateChannel: spyObservable('updateChannel'),
-    };
-}

admin-ui/src/testing/testing-common.module.ts

@@ -3,7 +3,6 @@ import { NgModule, Provider } from '@angular/core';
 import { ClarityModule } from '@clr/angular';
 
 import { DataService } from '../app/data/providers/data.service';
-import { MockDataService } from '../app/data/providers/data.service.mock';
 import { FormFieldControlDirective } from '../app/shared/components/form-field/form-field-control.directive';
 import { FormFieldComponent } from '../app/shared/components/form-field/form-field.component';
 
@@ -11,7 +10,7 @@ import { MockTranslatePipe } from './translate.pipe.mock';
 
 const DECLARATIONS = [MockTranslatePipe, FormFieldComponent, FormFieldControlDirective];
 
-const PROVIDERS: Provider[] = [{ provide: DataService, useClass: MockDataService }];
+const PROVIDERS: Provider[] = [{ provide: DataService, useValue: {} }];
 
 /**
  * This module is for use in unit testing, and provides common directives and providers