Browse Source

fix(core): Demote 404 errors to Verbose log level

Relates to #1335. In production, bots & exploit scanners typically produce hundreds of 404s on any
public server. This is just useless noise and in any case better analyzed in the gateway server
(nginx/apache) logs which contain IP address etc.
Michael Bromley 4 years ago
parent
commit
6b3c3fee99
1 changed files with 3 additions and 4 deletions
  1. 3 4
      packages/core/src/api/middleware/exception-logger.filter.ts

+ 3 - 4
packages/core/src/api/middleware/exception-logger.filter.ts

@@ -43,12 +43,11 @@ export class ExceptionLoggerFilter implements ExceptionFilter {
             // Handle other Nestjs errors
             statusCode = exception.getStatus();
             message = exception.message;
-            let stack = exception.stack;
             if (statusCode === 404) {
-                message = exception.message;
-                stack = undefined;
+                Logger.verbose(exception.message);
+            } else {
+                Logger.error(message, undefined, exception.stack);
             }
-            Logger.error(message, undefined, stack);
         } else {
             Logger.error(exception.message, undefined, exception.stack);
         }