Browse Source

fix(server): Allow same user to be logged in concurrently

Relates to #53
Michael Bromley 6 years ago
parent
commit
80d09d88f9
2 changed files with 7 additions and 2 deletions
  1. 1 1
      server/package.json
  2. 6 1
      server/src/service/services/auth.service.ts

+ 1 - 1
server/package.json

@@ -1,6 +1,6 @@
 {
 {
   "name": "@vendure/core",
   "name": "@vendure/core",
-  "version": "0.1.0-alpha.14",
+  "version": "0.1.0-alpha.15",
   "description": "A modern, headless ecommerce framework",
   "description": "A modern, headless ecommerce framework",
   "repository": {
   "repository": {
     "type": "git",
     "type": "git",

+ 6 - 1
server/src/service/services/auth.service.ts

@@ -48,7 +48,12 @@ export class AuthService {
         if (this.configService.authOptions.requireVerification && !user.verified) {
         if (this.configService.authOptions.requireVerification && !user.verified) {
             throw new NotVerifiedError();
             throw new NotVerifiedError();
         }
         }
-        await this.deleteSessionsByUser(user);
+        // TODO: this line is commented out so that the same user may be logged
+        // in more than once concurrently. At this time, it is needed in order
+        // for the online demo to work properly, but it may be desirable to keep it
+        // this way by design. See https://github.com/vendure-ecommerce/vendure/issues/53
+        // await this.deleteSessionsByUser(user);
+
         if (ctx.session && ctx.session.activeOrder) {
         if (ctx.session && ctx.session.activeOrder) {
             await this.deleteSessionsByActiveOrder(ctx.session && ctx.session.activeOrder);
             await this.deleteSessionsByActiveOrder(ctx.session && ctx.session.activeOrder);
         }
         }