Browse Source

chore(cli): Fix Sonar issues

Michael Bromley 3 months ago
parent
commit
847a530e63

+ 1 - 1
packages/cli/src/commands/schema/generate-schema/generate-schema.ts

@@ -10,7 +10,7 @@ import {
 } from '@vendure/core';
 import { writeFileSync } from 'fs-extra';
 import { getIntrospectionQuery, graphqlSync, printSchema } from 'graphql';
-import path from 'path';
+import path from 'node:path';
 
 import { loadVendureConfigFile } from '../../../shared/load-vendure-config-file';
 import { analyzeProject } from '../../../shared/shared-prompts';

+ 10 - 4
packages/cli/src/shared/load-vendure-config-file.ts

@@ -28,16 +28,18 @@ export async function loadVendureConfigFile(
         try {
             tsConfigFileContent = readFileSync(tsConfigPath, 'utf-8');
         } catch (error: unknown) {
-            const errorMessage = error instanceof Error ? error.message : String(error);
-            throw new Error(`Failed to read TypeScript config file at ${tsConfigPath}: ${errorMessage}`);
+            throw new Error(
+                `Failed to read TypeScript config file at ${tsConfigPath}: ${getErrorMessage(error)}`,
+            );
         }
 
         try {
             const { default: stripJsonComments } = await import('strip-json-comments');
             tsConfigJson = JSON.parse(stripJsonComments(tsConfigFileContent));
         } catch (error: unknown) {
-            const errorMessage = error instanceof Error ? error.message : String(error);
-            throw new Error(`Failed to parse TypeScript config file at ${tsConfigPath}: ${errorMessage}`);
+            throw new Error(
+                `Failed to parse TypeScript config file at ${tsConfigPath}: ${getErrorMessage(error)}`,
+            );
         }
 
         const compilerOptions = tsConfigJson.compilerOptions;
@@ -62,3 +64,7 @@ export async function loadVendureConfigFile(
     const configModule = await import(vendureConfig.sourceFile.getFilePath());
     return configModule[exportedVarName];
 }
+
+function getErrorMessage(error: unknown): string {
+    return error instanceof Error ? error.message : String(error);
+}

+ 1 - 1
packages/cli/src/utilities/monorepo-utils.ts

@@ -1,5 +1,5 @@
 import fs from 'fs-extra';
-import path from 'path';
+import path from 'node:path';
 
 /**
  * Common monorepo directory names (e.g., Nx, Turborepo, Lerna conventions)