refactor(core): Minor refactor to search job buffers

Relates to #1433

packages/core/src/plugin/default-search-plugin/search-job-buffer/collection-job-buffer.ts

@@ -3,7 +3,6 @@ import { unique } from '@vendure/common/lib/unique';
 
 import { Job, JobBuffer } from '../../../job-queue/index';
 import { ApplyCollectionFiltersJobData } from '../../../service/services/collection.service';
-import { UpdateIndexQueueJobData, UpdateVariantsByIdJobData, UpdateVariantsJobData } from '../types';
 
 export class CollectionJobBuffer implements JobBuffer<ApplyCollectionFiltersJobData> {
     readonly id = 'search-plugin-apply-collection-filters';
@@ -27,7 +26,6 @@ export class CollectionJobBuffer implements JobBuffer<ApplyCollectionFiltersJobD
                 applyToChangedVariantsOnly: referenceJob.data.applyToChangedVariantsOnly,
             },
         });
-
         return [batchedCollectionJob];
     }
 }

packages/core/src/plugin/default-search-plugin/search-job-buffer/search-index-job-buffer.ts

@@ -28,14 +28,14 @@ export class SearchIndexJobBuffer implements JobBuffer<UpdateIndexQueueJobData>
             collectedJobs,
             item => item.data.type === 'update-product',
         );
-
         const jobsToAdd = [...collectedJobs];
 
         if (variantsJobs.length) {
-            const variantIdsToUpdate = variantsJobs.reduce((result, job) => {
+            const variantIdsToUpdate: ID[] = [];
+            for (const job of variantsJobs) {
                 const ids = job.data.type === 'update-variants-by-id' ? job.data.ids : job.data.variantIds;
-                return [...result, ...ids];
-            }, [] as ID[]);
+                variantIdsToUpdate.push(...ids);
+            }
 
             const referenceJob = variantsJobs[0];
             const batchedVariantJob = new Job<UpdateVariantsByIdJobData>({
@@ -62,7 +62,6 @@ export class SearchIndexJobBuffer implements JobBuffer<UpdateIndexQueueJobData>
             }
             jobsToAdd.push(...(uniqueProductJobs as Job[]));
         }
-
         return jobsToAdd;
     }