refactor(server): Switch all ids to uuid strings

server/mock-data/mock-data-client.service.ts

@@ -97,7 +97,7 @@ export class MockDataClientService {
             );
 
             if (customer) {
-                const query2 = `mutation($customerId: Int!, $input: CreateAddressInput) {
+                const query2 = `mutation($customerId: String!, $input: CreateAddressInput) {
                                 createCustomerAddress(customerId: $customerId, input: $input) {
                                     id
                                     streetLine1

server/src/api/administrator/administrator.api.graphql

@@ -1,6 +1,6 @@
 type Query {
   administrators: [Administrator]
-  administrator(id: Int!): Administrator
+  administrator(id: String!): Administrator
 }
 
 type Mutation {

server/src/api/customer/customer.api.graphql

@@ -1,13 +1,13 @@
 type Query {
   customers(take: Int, skip: Int): CustomerList
-  customer(id: Int!): Customer
+  customer(id: String!): Customer
 }
 
 type Mutation {
   "Create a new Customer. If a password is provided, a new User will also be created an linked to the Customer."
   createCustomer(input: CreateCustomerInput!, password: String): Customer
   "Create a new Address and associate it with the Customer specified by customerId"
-  createCustomerAddress(customerId: Int, input: CreateAddressInput): Address
+  createCustomerAddress(customerId: String, input: CreateAddressInput): Address
 }
 
 type CustomerList implements PaginatedList {

server/src/api/product-option/product-option.api.graphql

@@ -1,6 +1,6 @@
 type Query {
     productOptionGroups(languageCode: LanguageCode): [ProductOptionGroup]
-    productOptionGroup(id: Int!, languageCode: LanguageCode): ProductOptionGroup
+    productOptionGroup(id: String!, languageCode: LanguageCode): ProductOptionGroup
 }
 
 type Mutation {

server/src/api/product/product.api.graphql

@@ -1,6 +1,6 @@
 type Query {
     products(languageCode: LanguageCode, take: Int, skip: Int): ProductList
-    product(id: Int!, languageCode: LanguageCode): Product
+    product(id: String!, languageCode: LanguageCode): Product
 }
 
 type Mutation {

server/src/common/common-types.graphql

@@ -4,5 +4,5 @@ interface PaginatedList {
 }
 
 interface Node {
-    id: Int!
+    id: String!
 }

server/src/entity/address/address.entity.ts

@@ -10,7 +10,7 @@ export class Address {
         }
     }
 
-    @PrimaryGeneratedColumn() id: number;
+    @PrimaryGeneratedColumn('uuid') id: string;
 
     @ManyToOne(type => Customer, customer => customer.addresses)
     customer: Customer;

server/src/entity/address/address.graphql

@@ -1,5 +1,5 @@
 type Address implements Node {
-  id: Int!
+  id: String!
   fullName: String
   company: String
   streetLine1: String

server/src/entity/administrator/administrator.entity.ts

@@ -18,7 +18,7 @@ export class Administrator {
         }
     }
 
-    @PrimaryGeneratedColumn() id: number;
+    @PrimaryGeneratedColumn('uuid') id: string;
 
     @Column() firstName: string;
 

server/src/entity/administrator/administrator.graphql

@@ -1,5 +1,5 @@
 type Administrator implements Node {
-    id: Int!
+    id: String!
     firstName: String
     lastName: String
     emailAddress: String

server/src/entity/customer/customer.entity.ts

@@ -20,7 +20,7 @@ export class Customer {
         }
     }
 
-    @PrimaryGeneratedColumn() id: number;
+    @PrimaryGeneratedColumn('uuid') id: string;
 
     @Column() firstName: string;
 

server/src/entity/customer/customer.graphql

@@ -1,5 +1,5 @@
 type Customer implements Node {
-  id: Int!
+  id: String!
   firstName: String
   lastName: String
   phoneNumber: String

server/src/entity/product-option-group/product-option-group-translation.entity.ts

@@ -12,7 +12,7 @@ export class ProductOptionGroupTranslation implements Translation<ProductOptionG
         }
     }
 
-    @PrimaryGeneratedColumn() id: number;
+    @PrimaryGeneratedColumn('uuid') id: string;
 
     @Column() languageCode: LanguageCode;
 

server/src/entity/product-option-group/product-option-group.dto.ts

@@ -8,6 +8,6 @@ export interface CreateProductOptionGroupDto extends TranslatedInput<ProductOpti
 }
 
 export interface UpdateProductOptionGroupDto extends TranslatedInput<ProductOptionGroup> {
-    id: number;
+    id: string;
     code: string;
 }

server/src/entity/product-option-group/product-option-group.entity.ts

@@ -12,7 +12,7 @@ export class ProductOptionGroup implements Translatable {
         }
     }
 
-    @PrimaryGeneratedColumn() id: number;
+    @PrimaryGeneratedColumn('uuid') id: string;
 
     name: LocaleString;
 

server/src/entity/product-option-group/product-option-group.graphql

@@ -1,5 +1,5 @@
 type ProductOptionGroup implements Node {
-    id: Int!
+    id: String!
     languageCode: LanguageCode
     code: String
     name: String
@@ -8,13 +8,13 @@ type ProductOptionGroup implements Node {
 }
 
 type ProductOptionGroupTranslation {
-    id: Int!
+    id: String!
     languageCode: LanguageCode!
     name: String!
 }
 
 input ProductOptionGroupTranslationInput {
-    id: Int
+    id: String
     languageCode: LanguageCode!
     name: String!
 }
@@ -26,7 +26,7 @@ input CreateProductOptionGroupInput {
 }
 
 input UpdateProductOptionGroupInput {
-    id: Int!
+    id: String!
     code: String!
     translations: [ProductOptionGroupTranslationInput]!
 }

server/src/entity/product-option/product-option-translation.entity.ts

@@ -12,7 +12,7 @@ export class ProductOptionTranslation implements Translation<ProductOption> {
         }
     }
 
-    @PrimaryGeneratedColumn() id: number;
+    @PrimaryGeneratedColumn('uuid') id: string;
 
     @Column() languageCode: LanguageCode;
 

server/src/entity/product-option/product-option.entity.ts

@@ -20,7 +20,7 @@ export class ProductOption implements Translatable {
         }
     }
 
-    @PrimaryGeneratedColumn() id: number;
+    @PrimaryGeneratedColumn('uuid') id: string;
 
     name: LocaleString;
 

server/src/entity/product-option/product-option.graphql

@@ -1,5 +1,5 @@
 type ProductOption implements Node {
-    id: Int!
+    id: String!
     languageCode: LanguageCode
     code: String
     name: String
@@ -7,13 +7,13 @@ type ProductOption implements Node {
 }
 
 type ProductOptionTranslation {
-    id: Int!
+    id: String!
     languageCode: LanguageCode!
     name: String!
 }
 
 input ProductOptionTranslationInput {
-    id: Int
+    id: String
     languageCode: LanguageCode!
     name: String!
 }

server/src/entity/product-variant/product-variant-translation.entity.ts

@@ -12,7 +12,7 @@ export class ProductVariantTranslation implements Translation<ProductVariant> {
         }
     }
 
-    @PrimaryGeneratedColumn() id: number;
+    @PrimaryGeneratedColumn('uuid') id: string;
 
     @Column() languageCode: LanguageCode;
 

server/src/entity/product-variant/product-variant.entity.ts

@@ -23,7 +23,7 @@ export class ProductVariant implements Translatable {
         }
     }
 
-    @PrimaryGeneratedColumn() id: number;
+    @PrimaryGeneratedColumn('uuid') id: string;
 
     name: LocaleString;
 

server/src/entity/product-variant/product-variant.graphql

@@ -1,5 +1,5 @@
 type ProductVariant implements Node {
-    id: Int!
+    id: String!
     sku: String
     name: String
     image: String
@@ -9,7 +9,7 @@ type ProductVariant implements Node {
 }
 
 type ProductVariantTranslation {
-    id: Int!
+    id: String!
     languageCode: LanguageCode!
     name: String!
 }

server/src/entity/product/product-translation.entity.ts

@@ -12,7 +12,7 @@ export class ProductTranslation implements Translation<Product> {
         }
     }
 
-    @PrimaryGeneratedColumn() id: number;
+    @PrimaryGeneratedColumn('uuid') id: string;
 
     @Column() languageCode: LanguageCode;
 

server/src/entity/product/product.dto.ts

@@ -9,7 +9,7 @@ export interface CreateProductDto extends TranslatedInput<Product> {
 }
 
 export interface UpdateProductDto extends TranslatedInput<Product> {
-    id: number;
+    id: string;
     image?: string;
     optionGroupCodes?: [string];
 }

server/src/entity/product/product.entity.ts

@@ -22,7 +22,7 @@ export class Product implements Translatable {
         }
     }
 
-    @PrimaryGeneratedColumn() id: number;
+    @PrimaryGeneratedColumn('uuid') id: string;
 
     name: LocaleString;
 

server/src/entity/product/product.graphql

@@ -1,5 +1,5 @@
 type Product implements Node {
-    id: Int!
+    id: String!
     languageCode: LanguageCode
     name: String
     slug: String
@@ -11,7 +11,7 @@ type Product implements Node {
 }
 
 type ProductTranslation {
-    id: Int!
+    id: String!
     languageCode: LanguageCode!
     name: String!
     slug: String!
@@ -19,7 +19,7 @@ type ProductTranslation {
 }
 
 input ProductTranslationInput {
-    id: Int
+    id: String
     languageCode: LanguageCode!
     name: String!
     slug: String
@@ -34,7 +34,7 @@ input CreateProductInput {
 }
 
 input UpdateProductInput {
-    id: Int!
+    id: String!
     image: String
     translations: [ProductTranslationInput]!
     optionGroupCodes: [String]

server/src/entity/user/user.entity.ts

@@ -4,7 +4,7 @@ import { Address } from '../address/address.entity';
 
 @Entity('user')
 export class User {
-    @PrimaryGeneratedColumn() id: number;
+    @PrimaryGeneratedColumn('uuid') id: string;
 
     @Column({ unique: true })
     identifier: string;

server/src/entity/user/user.graphql

@@ -1,5 +1,5 @@
 type User implements Node {
-    id: Int!
+    id: String!
     identifier: String
     passwordHash: String
     roles: [String]

server/src/locale/locale-types.ts

@@ -23,7 +23,7 @@ export interface Translatable { translations: Array<Translation<any>>; }
 export type Translation<T> =
     // Translation must include the languageCode and a reference to the base Translatable entity it is associated with
     {
-        id: number;
+        id: string;
         languageCode: LanguageCode;
         base: T;
     } &
@@ -33,7 +33,7 @@ export type Translation<T> =
 /**
  * This is the type of a translation object when provided as input to a create or update operation.
  */
-export type TranslationInput<T> = { [K in TranslatableKeys<T>]: string } & { id?: number; languageCode: LanguageCode };
+export type TranslationInput<T> = { [K in TranslatableKeys<T>]: string } & { id?: string; languageCode: LanguageCode };
 
 /**
  * This interface defines the shape of a DTO used to create / update an entity which has one or more LocaleString

server/src/locale/translate-entity.spec.ts

@@ -23,7 +23,7 @@ describe('translateEntity()', () => {
 
     beforeEach(() => {
         productTranslationEN = new ProductTranslation({
-            id: 2,
+            id: '2',
             languageCode: LanguageCode.EN,
             name: PRODUCT_NAME_EN,
             slug: '',
@@ -32,7 +32,7 @@ describe('translateEntity()', () => {
         productTranslationEN.base = { id: 1 } as any;
 
         productTranslationDE = new ProductTranslation({
-            id: 3,
+            id: '3',
             languageCode: LanguageCode.DE,
             name: PRODUCT_NAME_DE,
             slug: '',
@@ -41,7 +41,7 @@ describe('translateEntity()', () => {
         productTranslationDE.base = { id: 1 } as any;
 
         product = new Product();
-        product.id = 1;
+        product.id = '1';
         product.translations = [productTranslationEN, productTranslationDE];
     });
 
@@ -54,7 +54,7 @@ describe('translateEntity()', () => {
     it('should not overwrite translatable id with translation id', () => {
         const result = translateEntity(product, LanguageCode.EN);
 
-        expect(result).toHaveProperty('id', 1);
+        expect(result).toHaveProperty('id', '1');
     });
 
     it('should note transfer the base from the selected translation', () => {
@@ -93,7 +93,7 @@ describe('translateDeep()', () => {
     }
 
     class TestProductEntity implements Translatable {
-        id: number;
+        id: string;
         singleTestVariant: TestVariantEntity;
         singleRealVariant: ProductVariant;
         translations: Array<Translation<TestProduct>>;
@@ -104,7 +104,7 @@ describe('translateDeep()', () => {
     }
 
     class TestVariantEntity implements Translatable {
-        id: number;
+        id: string;
         singleOption: ProductOption;
         translations: Array<Translation<TestVariant>>;
     }
@@ -120,31 +120,31 @@ describe('translateDeep()', () => {
 
     beforeEach(() => {
         productTranslation = new ProductTranslation();
-        productTranslation.id = 2;
+        productTranslation.id = '2';
         productTranslation.languageCode = LANGUAGE_CODE;
         productTranslation.name = PRODUCT_NAME_EN;
 
         productOptionTranslation = new ProductOptionTranslation();
-        productOptionTranslation.id = 31;
+        productOptionTranslation.id = '31';
         productOptionTranslation.languageCode = LANGUAGE_CODE;
         productOptionTranslation.name = OPTION_NAME_EN;
 
         productOption = new ProductOption();
-        productOption.id = 3;
+        productOption.id = '3';
         productOption.translations = [productOptionTranslation];
 
         productVariantTranslation = new ProductVariantTranslation();
-        productVariantTranslation.id = 41;
+        productVariantTranslation.id = '41';
         productVariantTranslation.languageCode = LANGUAGE_CODE;
         productVariantTranslation.name = VARIANT_NAME_EN;
 
         productVariant = new ProductVariant();
-        productVariant.id = 3;
+        productVariant.id = '3';
         productVariant.translations = [productVariantTranslation];
         productVariant.options = [productOption];
 
         product = new Product();
-        product.id = 1;
+        product.id = '1';
         product.translations = [productTranslation];
         product.variants = [productVariant];
 

server/src/locale/translation-updater.spec.ts

@@ -9,20 +9,20 @@ describe('TranslationUpdater', () => {
     describe('diff()', () => {
         const existing: ProductTranslation[] = [
             {
-                id: 10,
+                id: '10',
                 languageCode: LanguageCode.EN,
                 name: '',
                 slug: '',
                 description: '',
-                base: 1 as any,
+                base: '1' as any,
             },
             {
-                id: 11,
+                id: '11',
                 languageCode: LanguageCode.DE,
                 name: '',
                 slug: '',
                 description: '',
-                base: 1 as any,
+                base: '1' as any,
             },
         ];
 

server/src/service/administrator.service.ts

@@ -15,7 +15,7 @@ export class AdministratorService {
         return this.connection.manager.find(Administrator);
     }
 
-    findOne(administratorId: number): Promise<Administrator | undefined> {
+    findOne(administratorId: string): Promise<Administrator | undefined> {
         return this.connection.manager.findOne(Administrator, administratorId);
     }
 

server/src/service/customer.service.ts

@@ -24,11 +24,11 @@ export class CustomerService {
             .then(([items, totalItems]) => ({ items, totalItems }));
     }
 
-    findOne(userId: number): Promise<Customer | undefined> {
+    findOne(userId: string): Promise<Customer | undefined> {
         return this.connection.manager.findOne(Customer, userId);
     }
 
-    findAddressesByCustomerId(customerId: number): Promise<Address[]> {
+    findAddressesByCustomerId(customerId: string): Promise<Address[]> {
         return this.connection
             .getRepository(Address)
             .createQueryBuilder('address')
@@ -51,7 +51,7 @@ export class CustomerService {
         return this.connection.getRepository(Customer).save(customer);
     }
 
-    async createAddress(customerId: number, createAddressDto: CreateAddressDto): Promise<Address> {
+    async createAddress(customerId: string, createAddressDto: CreateAddressDto): Promise<Address> {
         const customer = await this.connection.manager.findOne(Customer, customerId, { relations: ['addresses'] });
 
         if (!customer) {

server/src/service/product-option-group.service.ts

@@ -27,7 +27,7 @@ export class ProductOptionGroupService {
             .then(groups => groups.map(group => translateDeep(group, lang, ['options'])));
     }
 
-    findOne(id: number, lang: LanguageCode): Promise<ProductOptionGroup | undefined> {
+    findOne(id: string, lang: LanguageCode): Promise<ProductOptionGroup | undefined> {
         return this.connection.manager
             .findOne(ProductOptionGroup, id, {
                 relations: ['options'],

server/src/service/product-option.service.ts

@@ -21,7 +21,7 @@ export class ProductOptionService {
             .then(groups => groups.map(group => translateDeep(group, lang)));
     }
 
-    findOne(id: number, lang: LanguageCode): Promise<ProductOption | undefined> {
+    findOne(id: string, lang: LanguageCode): Promise<ProductOption | undefined> {
         return this.connection.manager
             .findOne(ProductOption, id, {
                 relations: ['group'],

server/src/service/product.service.spec.ts

@@ -113,7 +113,7 @@ describe('ProductService', () => {
             translationUpdater.applyDiff.mockReturnValue(Promise.resolve(productFromApplyDiffCall));
 
             const dto: UpdateProductDto = {
-                id: 1,
+                id: '1',
                 image: 'some-image',
                 translations: [],
             };

server/src/service/product.service.ts

@@ -39,7 +39,7 @@ export class ProductService {
             });
     }
 
-    findOne(productId: number, lang: LanguageCode): Promise<Product | undefined> {
+    findOne(productId: string, lang: LanguageCode): Promise<Product | undefined> {
         const relations = ['variants', 'optionGroups', 'variants.options'];
 
         return this.connection.manager