Browse Source

fix(core): Revert eager joining of OrderLine customField relations

Michael Bromley 3 years ago
parent
commit
b6220db20b

+ 0 - 4
packages/core/src/service/helpers/order-modifier/order-modifier.ts

@@ -140,9 +140,6 @@ export class OrderModifier {
             }),
         );
         await this.customFieldRelationService.updateRelations(ctx, OrderLine, { customFields }, orderLine);
-        const customFieldRelations = this.configService.customFields.OrderLine.filter(
-            field => field.type === 'relation',
-        ).map(field => `customFields.${field.name}`);
         const lineWithRelations = await this.connection.getEntityOrThrow(ctx, OrderLine, orderLine.id, {
             relations: [
                 'items',
@@ -150,7 +147,6 @@ export class OrderModifier {
                 'productVariant',
                 'productVariant.productVariantPrices',
                 'productVariant.taxCategory',
-                ...customFieldRelations,
             ],
         });
         lineWithRelations.productVariant = translateDeep(

+ 0 - 5
packages/core/src/service/services/order.service.ts

@@ -214,10 +214,6 @@ export class OrderService {
         relations?: RelationPaths<Order>,
     ): Promise<Order | undefined> {
         const qb = this.connection.getRepository(ctx, Order).createQueryBuilder('order');
-        const orderLineCustomFieldRelations = this.configService.customFields.OrderLine.filter(
-            field => field.type === 'relation',
-        ).map(field => `lines.customFields.${field.name}`);
-
         const effectiveRelations = relations ?? [
             'channels',
             'customer',
@@ -231,7 +227,6 @@ export class OrderService {
             'lines.productVariant.translations',
             'lines.featuredAsset',
             'lines.taxCategory',
-            ...orderLineCustomFieldRelations,
             'shippingLines',
             'surcharges',
         ];