Преглед изворни кода

refactor: Fix typings for RuntimeVendureConfig in plugins

Michael Bromley пре 6 година
родитељ
комит
c2623518c5

+ 3 - 3
packages/admin-ui-plugin/src/plugin.ts

@@ -5,7 +5,7 @@ import {
     createProxyHandler,
     OnVendureBootstrap,
     OnVendureClose,
-    VendureConfig,
+    RuntimeVendureConfig,
     VendurePlugin,
 } from '@vendure/core';
 import express from 'express';
@@ -82,7 +82,7 @@ export interface AdminUiOptions {
  * @docsCategory AdminUiPlugin
  */
 @VendurePlugin({
-    configuration: (config: Required<VendureConfig>) => AdminUiPlugin.configure(config),
+    configuration: config => AdminUiPlugin.configure(config),
 })
 export class AdminUiPlugin implements OnVendureBootstrap, OnVendureClose {
     private static options: AdminUiOptions;
@@ -98,7 +98,7 @@ export class AdminUiPlugin implements OnVendureBootstrap, OnVendureClose {
     }
 
     /** @internal */
-    static async configure(config: Required<VendureConfig>): Promise<Required<VendureConfig>> {
+    static async configure(config: RuntimeVendureConfig): Promise<RuntimeVendureConfig> {
         const route = 'admin';
         config.middleware.push({
             handler: createProxyHandler({ ...this.options, route, label: 'Admin UI' }),

+ 3 - 3
packages/asset-server-plugin/src/plugin.ts

@@ -5,7 +5,7 @@ import {
     LocalAssetStorageStrategy,
     OnVendureBootstrap,
     OnVendureClose,
-    VendureConfig,
+    RuntimeVendureConfig,
     VendurePlugin,
 } from '@vendure/core';
 import express, { NextFunction, Request, Response } from 'express';
@@ -186,7 +186,7 @@ export interface AssetServerOptions {
  * @docsCategory AssetServerPlugin
  */
 @VendurePlugin({
-    configuration: (config: Required<VendureConfig>) => AssetServerPlugin.configure(config),
+    configuration: config => AssetServerPlugin.configure(config),
 })
 export class AssetServerPlugin implements OnVendureBootstrap, OnVendureClose {
     private server: Server;
@@ -211,7 +211,7 @@ export class AssetServerPlugin implements OnVendureBootstrap, OnVendureClose {
     }
 
     /** @internal */
-    static configure(config: Required<VendureConfig>) {
+    static configure(config: RuntimeVendureConfig) {
         this.assetStorage = this.createAssetStorageStrategy(this.options);
         config.assetOptions.assetPreviewStrategy = new SharpAssetPreviewStrategy({
             maxWidth: this.options.previewMaxWidth || 1600,

+ 3 - 5
packages/email-plugin/src/plugin.ts

@@ -6,8 +6,8 @@ import {
     Logger,
     OnVendureBootstrap,
     OnVendureClose,
+    RuntimeVendureConfig,
     Type,
-    VendureConfig,
     VendurePlugin,
 } from '@vendure/core';
 import fs from 'fs-extra';
@@ -134,7 +134,7 @@ import {
  */
 @VendurePlugin({
     imports: [EventBusModule],
-    configuration: (config: Required<VendureConfig>) => EmailPlugin.configure(config),
+    configuration: config => EmailPlugin.configure(config),
 })
 export class EmailPlugin implements OnVendureBootstrap, OnVendureClose {
     private static options: EmailPluginOptions | EmailPluginDevModeOptions;
@@ -156,9 +156,7 @@ export class EmailPlugin implements OnVendureBootstrap, OnVendureClose {
     }
 
     /** @internal */
-    static configure(
-        config: Required<VendureConfig>,
-    ): Required<VendureConfig> | Promise<Required<VendureConfig>> {
+    static configure(config: RuntimeVendureConfig): RuntimeVendureConfig {
         if (isDevModeOptions(this.options) && this.options.mailboxPort !== undefined) {
             const route = 'mailbox';
             config.middleware.push({