fix(server): Revert using Nest's onModuleInit hook to run service setup

This reverts commit d300978c. When using onModuleInit, we cannot guarantee the order of execution, which breaks the initial bootstrap.

server/src/service/helpers/order-calculator/order-calculator.spec.ts

@@ -46,7 +46,8 @@ describe('OrderCalculator', () => {
             taxZoneStrategy: new DefaultTaxZoneStrategy(),
             taxCalculationStrategy: new DefaultTaxCalculationStrategy(),
         };
-        await module.init();
+        const taxRateService = module.get(TaxRateService);
+        await taxRateService.initTaxRates();
     });
 
     function createOrder(

server/src/service/helpers/tax-calculator/tax-calculator.spec.ts

@@ -37,12 +37,14 @@ describe('TaxCalculator', () => {
                 { provide: ListQueryBuilder, useValue: {} },
             ],
         }).compile();
+
         taxCalculator = module.get(TaxCalculator);
+        const taxRateService = module.get(TaxRateService);
         const mockConfigService = module.get<ConfigService, MockConfigService>(ConfigService);
         mockConfigService.taxOptions = {
             taxCalculationStrategy: new DefaultTaxCalculationStrategy(),
         };
-        await module.init();
+        await taxRateService.initTaxRates();
     });
 
     describe('with prices which do not include tax', () => {

server/src/service/service.module.ts

@@ -1,4 +1,4 @@
-import { Module } from '@nestjs/common';
+import { Module, OnModuleInit } from '@nestjs/common';
 import { TypeOrmModule } from '@nestjs/typeorm';
 
 import { getConfig } from '../config/config-helpers';
@@ -89,4 +89,28 @@ const exportedProviders = [
     ],
     exports: exportedProviders,
 })
-export class ServiceModule {}
+export class ServiceModule implements OnModuleInit {
+    constructor(
+        private channelService: ChannelService,
+        private roleService: RoleService,
+        private administratorService: AdministratorService,
+        private taxRateService: TaxRateService,
+        private shippingMethodService: ShippingMethodService,
+        private paymentMethodService: PaymentMethodService,
+    ) {}
+
+    async onModuleInit() {
+        // IMPORTANT - why manually invoke these init methods rather than just relying on
+        // Nest's "onModuleInit" lifecycle hook within each individual service class?
+        // The reason is that the order of invokation matters. By explicitly invoking the
+        // methods below, we can e.g. guarantee that the default channel exists
+        // (channelService.initChannels()) before we try to create any roles (which assume that
+        // there is a default Channel to work with.
+        await this.channelService.initChannels();
+        await this.roleService.initRoles();
+        await this.administratorService.initAdministrators();
+        await this.taxRateService.initTaxRates();
+        await this.shippingMethodService.initShippingMethods();
+        await this.paymentMethodService.initPaymentMethods();
+    }
+}

server/src/service/services/administrator.service.ts

@@ -1,4 +1,4 @@
-import { Injectable, OnModuleInit } from '@nestjs/common';
+import { Injectable } from '@nestjs/common';
 import { InjectConnection } from '@nestjs/typeorm';
 import { Connection } from 'typeorm';
 
@@ -17,7 +17,7 @@ import { RoleService } from './role.service';
 import { UserService } from './user.service';
 
 @Injectable()
-export class AdministratorService implements OnModuleInit {
+export class AdministratorService {
     constructor(
         @InjectConnection() private connection: Connection,
         private listQueryBuilder: ListQueryBuilder,
@@ -26,7 +26,7 @@ export class AdministratorService implements OnModuleInit {
         private roleService: RoleService,
     ) {}
 
-    async onModuleInit() {
+    async initAdministrators() {
         await this.ensureSuperAdminExists();
     }
 

server/src/service/services/channel.service.ts

@@ -1,4 +1,4 @@
-import { Injectable, OnModuleInit } from '@nestjs/common';
+import { Injectable } from '@nestjs/common';
 import { InjectConnection } from '@nestjs/typeorm';
 import { Connection } from 'typeorm';
 
@@ -18,7 +18,7 @@ import { getEntityOrThrow } from '../helpers/utils/get-entity-or-throw';
 import { patchEntity } from '../helpers/utils/patch-entity';
 
 @Injectable()
-export class ChannelService implements OnModuleInit {
+export class ChannelService {
     private allChannels: Channel[] = [];
 
     constructor(@InjectConnection() private connection: Connection, private configService: ConfigService) {}
@@ -27,7 +27,7 @@ export class ChannelService implements OnModuleInit {
      * When the app is bootstrapped, ensure a default Channel exists and populate the
      * channel lookup array.
      */
-    async onModuleInit() {
+    async initChannels() {
         await this.ensureDefaultChannelExists();
         await this.updateAllChannels();
     }

server/src/service/services/payment-method.service.ts

@@ -1,4 +1,4 @@
-import { Injectable, OnModuleInit } from '@nestjs/common';
+import { Injectable } from '@nestjs/common';
 import { InjectConnection } from '@nestjs/typeorm';
 import { Connection } from 'typeorm';
 
@@ -22,14 +22,14 @@ import { getEntityOrThrow } from '../helpers/utils/get-entity-or-throw';
 import { patchEntity } from '../helpers/utils/patch-entity';
 
 @Injectable()
-export class PaymentMethodService implements OnModuleInit {
+export class PaymentMethodService {
     constructor(
         @InjectConnection() private connection: Connection,
         private configService: ConfigService,
         private listQueryBuilder: ListQueryBuilder,
     ) {}
 
-    async onModuleInit() {
+    async initPaymentMethods() {
         await this.ensurePaymentMethodsExist();
     }
 

server/src/service/services/role.service.ts

@@ -1,4 +1,4 @@
-import { Injectable, OnModuleInit } from '@nestjs/common';
+import { Injectable } from '@nestjs/common';
 import { InjectConnection } from '@nestjs/typeorm';
 import { Connection } from 'typeorm';
 
@@ -20,14 +20,14 @@ import { patchEntity } from '../helpers/utils/patch-entity';
 import { ChannelService } from './channel.service';
 
 @Injectable()
-export class RoleService implements OnModuleInit {
+export class RoleService {
     constructor(
         @InjectConnection() private connection: Connection,
         private channelService: ChannelService,
         private listQueryBuilder: ListQueryBuilder,
     ) {}
 
-    async onModuleInit() {
+    async initRoles() {
         await this.ensureSuperAdminRoleExists();
         await this.ensureCustomerRoleExists();
     }

server/src/service/services/shipping-method.service.ts

@@ -1,4 +1,4 @@
-import { Injectable, OnModuleInit } from '@nestjs/common';
+import { Injectable } from '@nestjs/common';
 import { InjectConnection } from '@nestjs/typeorm';
 import { Connection } from 'typeorm';
 
@@ -24,7 +24,7 @@ import { patchEntity } from '../helpers/utils/patch-entity';
 import { ChannelService } from './channel.service';
 
 @Injectable()
-export class ShippingMethodService implements OnModuleInit {
+export class ShippingMethodService {
     shippingEligibilityCheckers: ShippingEligibilityChecker[];
     shippingCalculators: ShippingCalculator[];
     private activeShippingMethods: ShippingMethod[];
@@ -40,7 +40,7 @@ export class ShippingMethodService implements OnModuleInit {
         this.shippingCalculators = this.configService.shippingOptions.shippingCalculators || [];
     }
 
-    async onModuleInit() {
+    async initShippingMethods() {
         await this.updateActiveShippingMethods();
     }
 

server/src/service/services/tax-rate.service.ts

@@ -1,4 +1,3 @@
-import { OnModuleInit } from '@nestjs/common';
 import { InjectConnection } from '@nestjs/typeorm';
 import { Connection } from 'typeorm';
 
@@ -15,7 +14,7 @@ import { ListQueryBuilder } from '../helpers/list-query-builder/list-query-build
 import { getEntityOrThrow } from '../helpers/utils/get-entity-or-throw';
 import { patchEntity } from '../helpers/utils/patch-entity';
 
-export class TaxRateService implements OnModuleInit {
+export class TaxRateService {
     /**
      * We cache all active TaxRates to avoid hitting the DB many times
      * per request.
@@ -33,7 +32,7 @@ export class TaxRateService implements OnModuleInit {
         private listQueryBuilder: ListQueryBuilder,
     ) {}
 
-    async onModuleInit() {
+    async initTaxRates() {
         return this.updateActiveTaxRates();
     }