Merge pull request #153 from lsimone/fix-152

fix(race-condition): Fix race condition on DB among worker and server

packages/core/src/bootstrap.ts

@@ -2,7 +2,7 @@ import { INestApplication, INestMicroservice } from '@nestjs/common';
 import { NestFactory } from '@nestjs/core';
 import { TcpClientOptions, Transport } from '@nestjs/microservices';
 import { Type } from '@vendure/common/lib/shared-types';
-import { EntitySubscriberInterface } from 'typeorm';
+import { ConnectionOptions, EntitySubscriberInterface } from 'typeorm';
 
 import { InternalServerError } from './common/error/errors';
 import { ReadOnlyRequired } from './common/types/common-types';
@@ -17,6 +17,20 @@ import { logProxyMiddlewares } from './plugin/plugin-utils';
 
 export type VendureBootstrapFunction = (config: VendureConfig) => Promise<INestApplication>;
 
+/**
+ * https://github.com/vendure-ecommerce/vendure/issues/152
+ * fix race condition when modifying DB
+ * @param {VendureConfig} userConfig
+ */
+const disableSynchronize = (userConfig: ReadOnlyRequired<VendureConfig>): ReadOnlyRequired<VendureConfig> => {
+    const config = { ...userConfig };
+    config.dbConnectionOptions = {
+        ...userConfig.dbConnectionOptions,
+        synchronize: false,
+    } as ConnectionOptions;
+    return config;
+};
+
 /**
  * @description
  * Bootstraps the Vendure server. This is the entry point to the application.
@@ -97,7 +111,7 @@ export async function bootstrapWorker(userConfig: Partial<VendureConfig>): Promi
 }
 
 async function bootstrapWorkerInternal(userConfig: Partial<VendureConfig>): Promise<INestMicroservice> {
-    const config = await preBootstrapConfig(userConfig);
+    const config = disableSynchronize(await preBootstrapConfig(userConfig));
     if (!config.workerOptions.runInMainProcess && (config.logger as any).setDefaultContext) {
         (config.logger as any).setDefaultContext('Vendure Worker');
     }

packages/dev-server/index-worker.ts

@@ -2,6 +2,10 @@ import { bootstrapWorker } from '@vendure/core';
 
 import { devConfig } from './dev-config';
 
+// https://github.com/vendure-ecommerce/vendure/issues/152
+// fix race condition when modifying DB
+devConfig.dbConnectionOptions = { ...devConfig.dbConnectionOptions, synchronize: false };
+
 bootstrapWorker(devConfig).catch(err => {
     // tslint:disable-next-line
     console.log(err);